-
Notifications
You must be signed in to change notification settings - Fork 38
Customise buttons in adminapprove step #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customise buttons in adminapprove step #266
Conversation
bluetom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A cool thing, thank you for your work!
I’ll have a closer look at the code in the next few days.
version.php
Outdated
|
|
||
| $plugin->maturity = MATURITY_STABLE; | ||
| $plugin->version = 2025102300; | ||
| $plugin->version = 2025110400; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the version number in version.php to 2025102300.01?
Like Moodle HQ I only change the date for major updates.
Thank you very much,
Thomas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is ok.
But I do not know how to update the version.php in the pull request ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. github did the job for me :-)
🔀 Purpose of this PR:
📝 Description:
Please describe the purpose of this PR in a few sentences.
What feature or bug does it address?
Extends the adminapprove step by allowing the button labels to be customized
Why is this change or addition necessary?
We had a scenario where the default button texts cause confustion (proceeding meant stopping the course).
This PR also improves usability because it is easier to see what you are actually confirming in that admin approve step.
What is the expected behavior after the change?
📋 Checklist
Please confirm the following (check all that apply):
phpunitand/orbehattests that cover my changes or additions.var_dump()orvar_exportor any other debugging statements (or commented out code) thatshould not appear on the productive branch.
db/upgrade.phpandupdated the
version.php..minfiles with thegrunt amdcommand.version.phpand theCHANGES.md.I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
changes in the plugins UI.
🔍 Related Issues
🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)
Any other relevant information.