Skip to content

Conversation

@KBorm
Copy link

@KBorm KBorm commented Nov 6, 2025

Note: Please fill out all relevant sections and remove irrelevant ones.

🔀 Purpose of this PR:

  • Fixes a bug
  • Updates for a new Moodle version
  • Adds a new feature of functionality
  • Improves or enhances existing features
  • Refactoring: restructures code for better performance or maintainability
  • Testing: add missing or improve existing tests
  • Miscellaneous: code cleaning (without functional changes), documentation, configuration, ...

📝 Description:

Please describe the purpose of this PR in a few sentences.

  • What feature or bug does it address?
    Extends the adminapprove step by allowing the button labels to be customized

  • Why is this change or addition necessary?
    We had a scenario where the default button texts cause confustion (proceeding meant stopping the course).
    This PR also improves usability because it is easier to see what you are actually confirming in that admin approve step.

  • What is the expected behavior after the change?

  1. existing admin steps display as before
  2. no values set in adminapprove config means default behaviour
  3. values set will override buttons in approvals page and in active workflow page for adminapprove step

📋 Checklist

Please confirm the following (check all that apply):

  • I have phpunit and/or behat tests that cover my changes or additions.
  • Code passes the code checker without errors and warnings.
  • Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
  • Code does not have var_dump() or var_export or any other debugging statements (or commented out code) that
    should not appear on the productive branch.
  • Code only uses language strings instead of hard-coded strings.
  • [(x)] If there are changes in the database: I updated/created the necessary upgrade steps in db/upgrade.php and
    updated the version.php.
  • [(x)] If there are changes in javascript: I build new .min files with the grunt amd command.
  • [(x)] If it is a Moodle update PR: I read the release notes, updated the version.php and the CHANGES.md.
    I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
    changes in the plugins UI.

🔍 Related Issues

  • Related to #[IssueNumber]

🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)

Any other relevant information.


Copy link
Contributor

@bluetom bluetom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cool thing, thank you for your work!
I’ll have a closer look at the code in the next few days.

version.php Outdated

$plugin->maturity = MATURITY_STABLE;
$plugin->version = 2025102300;
$plugin->version = 2025110400;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the version number in version.php to 2025102300.01?
Like Moodle HQ I only change the date for major updates.
Thank you very much,
Thomas

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is ok.
But I do not know how to update the version.php in the pull request ;-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. github did the job for me :-)

@bluetom bluetom changed the base branch from main to develop_500 November 9, 2025 04:12
@bluetom bluetom merged commit c6377ac into learnweb:develop_500 Nov 9, 2025
17 checks passed
bluetom added a commit that referenced this pull request Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants