tile geometry metadata is not being set #4696
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added some metadata to expose tile geometry, but this is set in _load() when we add the tilecache, not in _header(), so it's not visible downstream because of lazy loading. Add a test, fix the test in the next commit. See #4637
it could return TRUE even if the buffer was not modified
non-functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added some metadata to expose tile geometry, but this is set in _load() when we add the tilecache, not in _header(), so it's not visible downstream because of lazy loading.
Add a test, fix the test in the next commit.
See #4637