Skip to content

Upgrade VSS encryption and obfuscation scheme #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 17, 2025
Merged

Upgrade VSS encryption and obfuscation scheme #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3d5013b
Introduce schema versioning
tnull Nov 11, 2025
65f6f7b
Use obf. key as `aad` for `StorableBuilder` and obfuscate namespaces
tnull Aug 22, 2025
86239cf
Prefactor: move client construction out to `VssStore`
tnull Nov 11, 2025
a375179
Only use internal runtime in `VssStore`
tnull Nov 3, 2025
2af8103
Drop redundant `tokio::timeout`s for VSS IO
tnull Nov 6, 2025
37ee256
Bump retries and timeouts considerably
tnull Nov 10, 2025
37ed5c4
Introduce two separate `VssClient`s for async/blocking contexts
tnull Nov 10, 2025
20a93c5
Determine VSS schema version at startup
tnull Nov 12, 2025
8e5503c
Add test ensuring backwards compatibility with VSS schema `v0`
tnull Nov 13, 2025
d2153f2
Add simple test ensuring we can restart from a VSS backend
tnull Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ serde = { version = "1.0.210", default-features = false, features = ["std", "der
serde_json = { version = "1.0.128", default-features = false, features = ["std"] }
log = { version = "0.4.22", default-features = false, features = ["std"]}

vss-client = "0.3"
vss-client = { package = "vss-client-ng", version = "0.4" }
prost = { version = "0.11.6", default-features = false}

[target.'cfg(windows)'.dependencies]
Expand All @@ -91,6 +91,9 @@ clightningrpc = { version = "0.3.0-beta.8", default-features = false }
lnd_grpc_rust = { version = "2.10.0", default-features = false }
tokio = { version = "1.37", features = ["fs"] }

[target.'cfg(vss_test)'.dev-dependencies]
ldk-node-062 = { package = "ldk-node", version = "=0.6.2" }

[build-dependencies]
uniffi = { version = "0.28.3", features = ["build"], optional = true }

Expand Down Expand Up @@ -151,3 +154,6 @@ harness = false
#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "21e9a9c0ef80021d0669f2a366f55d08ba8d9b03" }
#lightning-liquidity = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "21e9a9c0ef80021d0669f2a366f55d08ba8d9b03" }
#lightning-macros = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "21e9a9c0ef80021d0669f2a366f55d08ba8d9b03" }

#vss-client-ng = { path = "../vss-client" }
#vss-client-ng = { git = "https://github.com/lightningdevkit/vss-client", branch = "main" }
6 changes: 5 additions & 1 deletion src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,11 @@ impl NodeBuilder {
let vss_seed_bytes: [u8; 32] = vss_xprv.private_key.secret_bytes();

let vss_store =
VssStore::new(vss_url, store_id, vss_seed_bytes, header_provider, Arc::clone(&runtime));
VssStore::new(vss_url, store_id, vss_seed_bytes, header_provider).map_err(|e| {
log_error!(logger, "Failed to setup VSS store: {}", e);
BuildError::KVStoreSetupFailed
})?;

build_with_store_internal(
config,
self.chain_data_source_config.as_ref(),
Expand Down
Loading
Loading