Make Probe.Script a pointer #4227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
Change the type of "Script" under "type Probe struct" from "string" to "*string". Make it consistent with "Provision.Script". Check lima-vm#4211 for details. Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
My DCO line in this project is: But (in my opinion) it really is not necessary to put in |
jandubois
reviewed
Oct 19, 2025
| } | ||
| } | ||
| if !strings.HasPrefix(p.Script, "#!") { | ||
| if p.Script != nil && !strings.HasPrefix(*p.Script, "#!") { |
There was a problem hiding this comment.
The Validate function does not have to worry about the Script field being nil because it has been set by FillDefaults. Same is true for the provision Script references.
There was a problem hiding this comment.
Right, but doesn't seem to hurt checking it here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the following 2 changes:
provision.Scriptwith default value ( empty string"") inFillDefault()Check #4211 for related details.
Notes
@jandubois -
This is suggested by you.
Would you mind to share your signed-off tag with me so I can put it in the commit as `Suggested-by: ?