add new snowflake samples page #295
Conversation
HarshCasper
requested review from
quetzalliwrites and
remotesynth
as code owners
Deploying localstack-docs with
|
| Latest commit: |
f2f5742
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1120792d.localstack-docs.pages.dev |
| Branch Preview URL: | https://snowflake-sample-apps-page.localstack-docs.pages.dev |
There was a problem hiding this comment.
LGTM - left a minor comment.
I skimmed all astro-specific files, assuming they will be sound after your own careful checking and review from docs team.
Would like @hovaesco to double check the snowflake sample app metadata is correct if he has time e.g. in src/data/developerhub/applications.json
| "helm-charts": "Helm Charts", | ||
| "pulumi": "Pulumi" | ||
| "pulumi": "Pulumi", | ||
| "snowcli": "Snow CLI" |
There was a problem hiding this comment.
it's actually called Snowflake CLI (https://docs.snowflake.com/en/developer-guide/snowflake-cli/index)
confusingly there's a related older tool called SnowSQL (https://docs.snowflake.com/en/user-guide/snowsql)
There was a problem hiding this comment.
LGTM! Do we want to include multi-container app as well https://github.com/localstack-samples/localstack-snowflake-samples/tree/main/multi-container ?
| collapsed: true, | ||
| autogenerate: { directory: '/snowflake/integrations' }, | ||
| }, | ||
| { |
There was a problem hiding this comment.
do we want to maintain the same page order in the navigation panel as in AWS docs?
There was a problem hiding this comment.
I think it makes sense, although not critical. It gives our docs a consistent feel.
|
do you want us to merge it? @HarshCasper 😄 |
Yes. unless more work needs to be done for multi-container app to include it. If that's the case I'd raise another ticket for it. @HarshCasper can we include the multi-container app as is? |
Doesn't seem like Harsh had a chance to look at the review comments yet? @HarshCasper |
No description provided.