Allow some SalesSequence data to be retrieved by extensions for customisatioons #40237

workslop8264 · 2025-10-19T15:59:23Z

Description (*)

Being able to change the sequence generation for a specific entity type is a reasonably common request. The objective of this PR is to allow extensions to more easily modify this: currently, it is impossible without overriding the whole model (read: copy and paste, since everything is private).

This PR will allow extensions or vendors to change the format, for instance with an after plugin:

public function afterGetNextValue(
    \Magento\SalesSequence\Model\Sequence $subject,
    string $result
) {
    //If we're generating for an order, set its sequence to ECOM{STORE_ID}#{4 DIGIT INC. ID}
    if ('order' === $subject->getEntityType()) {
        return \sprintf('ECOM%d#%\'.04d', $subject->getStoreId(), $subject->calculateCurrentValue());
    }
    
    //Otherwise, passthrough
    return $result;
}

NB: this would probably be a good use case for some sort of expansion (having some di-defined array for entity types to calculate their values), but this is a good first step IMO.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

This is a transparent API change: it should not change anything. Perhaps trying an after plugin like mentioned above.

Questions or comments

Unsure re: unit tests. I've added some, but they seem superfluous.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…rofile & entity type in Magento_SalesSequence::Model/Sequence

…urrentValue public, add getStoreId() function

m2-assistant · 2025-10-19T15:59:27Z

Hi @workslop8264. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

ct-prd-pr-scan · 2025-10-19T15:59:33Z