Redesign System asset into Hardware asset #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 7, 2021
skatsikeas
approved these changes
Dec 15, 2021
Collaborator
skatsikeas
left a comment
skatsikeas
left a comment
There was a problem hiding this comment.
Those changes were discussed with Andrei in a meeting and I approve those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked the
Systemasset into theHardwareasset that is simpler and only represents, as the name suggests, the hardware components on whichApplicationsare run. This makes the distinction between hardware and software in coreLang clearer.This pull request also introduces
HardwareVulnerabilitieswhich are analogous, but less complex, than theSoftwareVulnerabilities. These are used to model vulnerabilities that both require physical access on and lead to disruptions(confidentiality, integrity, availability) on theHardwareasset. Vulnerabilities that require physical access but impact software(Applications/SoftwareProducts) are represented usingSoftwareVulnerabilitieswith thephysicalAccessRequireddefence enabled.Also included is an update to the
PhysicalZoneasset. BothNetworkandHardwareassets can be associated with aPhysicalZoneand each can belong to multiple zones, thus representing overlapping zones. This was initially requested by @jesajx(#39 (comment)).Usersnow can directly be associated with eitherHardwareorPhysicalZoneassets in order to represent the hardware/network assets that they have physical access to.Identitiescannot be associated withHardwareas they were with the oldSystemasset since privileges are only relevant for software assets.