MLE-24747 Fixing typo in Gradle file #1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't know why this didn't cause a failure initially, but did cause failures in nightly regressions.
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
Purpose: Correct a typo in the mockito-inline dependency version to resolve nightly regression failures.
- Updated mockito-inline version from 5.20.0 to 5.2.0.
- Leaves mockito-core at 5.20.0, resulting in a potential version mismatch between Mockito modules.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| testImplementation "org.mockito:mockito-core:5.20.0" | ||
| testImplementation "org.mockito:mockito-inline:5.20.0" | ||
| testImplementation "org.mockito:mockito-inline:5.2.0" |
There was a problem hiding this comment.
mockito-core and mockito-inline typically should use the same version to avoid classpath inconsistencies; consider aligning both to the intended version (e.g., 5.2.0 if 5.20.0 was the original typo) or update inline to match a valid core version if 5.20.0 is correct.
Suggested change
| testImplementation "org.mockito:mockito-inline:5.2.0" | |
| testImplementation "org.mockito:mockito-inline:5.20.0" |
BillFarber
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know why this didn't cause a failure initially, but did cause failures in nightly regressions.