-
Notifications
You must be signed in to change notification settings - Fork 74
MLE-24826 Bumping Spring, undertow for CVEs #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also bumped an old version of xmlunit. Pretty sure the junit:junit stuff can be easily removed next.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request addresses security vulnerabilities by bumping versions of Spring dependencies (through transitives), Undertow, and XMLUnit libraries.
Key changes:
- Updated Undertow from 2.3.19.Final to 2.3.20.Final to address CVEs
- Migrated XMLUnit from legacy 1.6 to modern 2.10.4 with updated Maven coordinates
- Updated JUnit Jupiter and ml-app-deployer dependencies to latest versions
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test-app/build.gradle | Updated Undertow core and servlet dependencies to version 2.3.20.Final |
| ml-development-tools/build.gradle | Migrated from xmlunit:xmlunit:1.6 to org.xmlunit:xmlunit-legacy:2.10.4 |
| marklogic-client-api/build.gradle | Updated JUnit Jupiter to 5.14.0 and ml-app-deployer to 6.2-SNAPSHOT |
| marklogic-client-api-functionaltests/build.gradle | Updated ml-app-deployer to 6.2-SNAPSHOT |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| // Allows talking to the Manage API. | ||
| testImplementation "com.marklogic:ml-app-deployer:6.1.0" | ||
| testImplementation "com.marklogic:ml-app-deployer:6.2-SNAPSHOT" |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a SNAPSHOT dependency in production code introduces instability, as the artifact can change without notice. Consider using a stable release version instead, or document why a SNAPSHOT is required.
| testImplementation "com.marklogic:ml-app-deployer:6.2-SNAPSHOT" | |
| testImplementation "com.marklogic:ml-app-deployer:6.2.0" |
| testImplementation 'org.apache.commons:commons-lang3:3.19.0' | ||
|
|
||
| testImplementation "com.marklogic:ml-app-deployer:6.1.0" | ||
| testImplementation "com.marklogic:ml-app-deployer:6.2-SNAPSHOT" |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a SNAPSHOT dependency in production code introduces instability, as the artifact can change without notice. Consider using a stable release version instead, or document why a SNAPSHOT is required.
| testImplementation "com.marklogic:ml-app-deployer:6.2-SNAPSHOT" | |
| testImplementation "com.marklogic:ml-app-deployer:6.2.0" |
Also bumped an old version of xmlunit. Pretty sure the junit:junit stuff can be easily removed next.