-
Notifications
You must be signed in to change notification settings - Fork 58
[continued as #1953] #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[continued as #1953] #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
979dd4f to
688c166
Compare
a72742a to
692515b
Compare
r0b1n
reviewed
Oct 16, 2025
packages/pluggableWidgets/datagrid-web/src/components/loader/SpinnerLoader.tsx
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Oct 16, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid.scss
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Oct 16, 2025
packages/pluggableWidgets/datagrid-web/src/components/CheckboxColumnHeader.tsx
Show resolved
Hide resolved
r0b1n
reviewed
Oct 16, 2025
packages/pluggableWidgets/datagrid-web/src/components/SelectAllBar.tsx
Outdated
Show resolved
Hide resolved
0471555 to
0f52cb0
Compare
r0b1n
reviewed
Oct 17, 2025
packages/pluggableWidgets/datagrid-web/src/features/data-export/DSExportRequest.ts
Show resolved
Hide resolved
r0b1n
reviewed
Oct 17, 2025
r0b1n
reviewed
Oct 17, 2025
packages/shared/widget-plugin-grid/src/select-all/SelectAllController.ts
Show resolved
Hide resolved
r0b1n
reviewed
Oct 17, 2025
packages/shared/widget-plugin-grid/src/select-all/SelectAllController.ts
Show resolved
Hide resolved
r0b1n
reviewed
Oct 17, 2025
packages/shared/widget-plugin-grid/src/stores/SelectionCountStore.ts
Outdated
Show resolved
Hide resolved
0f52cb0 to
eebfcd4
Compare
r0b1n
previously approved these changes
Oct 21, 2025
523c9a3 to
d296634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
This PR implements multi-page select all functionality for the Datagrid2 widget, allowing users to select all items across multiple pages based on the current filter. The feature includes configurable batch processing, progress tracking, and cancellation support, similar to the existing Excel export functionality.
What should be covered while testing?
Small dataset (< buffer size): Should use immediate selection
Large dataset (>= buffer size): Should show progress dialog and batch processing
Unknown total count: Should fall back to per-page selection
Cancellation: Should properly cancel and restore state
Page restoration: Should return user to original page after selection
Filtered data: Should only select items matching current filter