[wip][do not review] enable pipeline rl #549
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This change adds optional parameters to Generator.update_weights() to support in-flight weight updates without waiting for pending requests to complete. The original blocking behavior is preserved as default, with new opt-in parameters: - wait_for_pending (default=True): When False, updates weights immediately without draining the request queue - reset_cache (default=True): When False, preserves KV cache during updates This enables faster weight updates during training at the cost of potential mid-generation weight switching for in-flight requests. Test Plan: - Verified Python syntax compiles successfully - Default behavior unchanged (backwards compatible) - New behavior available via explicit parameter flags
meta-cla
bot
added
the
CLA Signed
Summary: Added two new configuration fields to the Generator dataclass: - wait_for_pending_on_update (default=True): Controls whether weight updates wait for pending requests to complete - reset_cache_on_update (default=True): Controls whether to reset KV cache after weight updates The update_weights() method now uses these config values as defaults, but still allows per-call overrides via optional parameters. This enables users to configure the behavior globally via config files while maintaining flexibility for per-call customization. Test Plan: - Verified Python syntax compiles successfully - Default behavior unchanged (backwards compatible) - Config values can be set in Generator instantiation - Per-call overrides still work as before
casteryh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds optional parameters to Generator.update_weights() to support in-flight weight updates without waiting for pending requests to complete.
Changes
wait_for_pendingandreset_cacheparameters toGenerator.update_weights()wait_for_pendingreset_cacheTest Plan