-
Notifications
You must be signed in to change notification settings - Fork 682
[E-Document Formats][Factura - E] - Migrate electronic formats to new purchase draft concept for e-invoicing (e-invoice preview) (Factura-E )(ES localization) #28985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GMatuleviciute
wants to merge
18
commits into
microsoft:main
Choose a base branch
from
GMatuleviciute:dev/aan/FacturaE-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements Spanish Factura-E electronic document format handler to enable reading and processing of incoming purchase invoices and credit memos. Provides XML parsing capabilities for Factura-E documents with automatic vendor lookup using VAT registration numbers, service participants, or name/address matching. Includes support for multi-currency transactions, tax calculations, and unit of measure conversions from international standard codes. Enables viewing of imported documents through dedicated purchase document reader interface.
Adds comprehensive XML documentation comments to all public and internal procedures to improve code maintainability and developer experience. Optimizes XML stream handling by eliminating intermediate variable and directly using CreateInStream method call. Enhances unit of measure conversion logic with better variable naming and clearer control flow structure. Updates database insert operation to use non-validated insert for better performance during line processing.
Remove documentation from local procedures
…te/ALAppExtensions into dev/aan/FacturaE-v2
…raftHandler.Codeunit.al
…eadintoDraft.EnumExt.al
Cleans up the dependencies section by removing the unused E-Document Format for PINT A-NZ extension reference. Streamlines the app configuration and eliminates unnecessary dependency declarations.
…aEHandler.Codeunit.al Co-authored-by: Grasiele Matuleviciute <131970463+GMatuleviciute@users.noreply.github.com>
…aEHandler.Codeunit.al Co-authored-by: Grasiele Matuleviciute <131970463+GMatuleviciute@users.noreply.github.com>
Reorders using statements alphabetically for better code organization. Adds Locked = true attribute to namespace labels to prevent translation, ensuring XML namespace URIs remain constant across different language configurations.
Updates variable naming to follow AL coding standards where token constants use 'Tok' suffix instead of 'Lbl' suffix. Changes apply to namespace URI constants and XPath expression constants used in XML processing.
Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link. |
Introduces a mock e-document format, validation helpers, and a sample Facturae XML to enable end-to-end tests for incoming invoice parsing and purchase document creation. Adds a reusable test library to set up services, workflows, master data, and mappings, and to drive inbound/import scenarios. Updates the test app manifest (ID range, target, resource folders) and includes a test dependency. Adds a routine to reset drafts by deleting the generated purchase draft, enabling clean test reruns and easier state management.
Removes OnPrem target to align tests with SaaS environments. Skips triggers on bulk delete/modify during setup to speed execution and reduce side effects/permission issues, improving test stability. Centralizes the test XML path in a reusable token and adds scenario-style comments for readability, plus minor cleanup.
Trims trailing blank line and removes final newline to align with repository formatting conventions. No functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does not have a related issue as it's part of the delivery for development agreed directly with @altotovi @Groenbech96
Implementation
Implements Spanish Factura-E electronic document format handler to enable reading and processing of incoming purchase invoices and credit memos (using new import process).
Provides XML parsing capabilities for Factura-E documents with automatic vendor lookup using VAT registration numbers, service participants, or name/address matching.
Includes support for multi-currency transactions, tax calculations, and unit of measure conversions from international standard codes.
Enables viewing of imported documents through dedicated purchase document reader interface.
Important
This Pull request depends on #28983
Fixes #