Add lib.esnext.temporal #62628

Renegade334 · 2025-10-19T12:12:41Z

No custom calendar support, as per the latest spec changes.

There are lots of places in the spec where property bags have "at least one of" constraints (eg. either month or monthCode is mandatory for a DateLikeObject), which can't really be straightforwardly expressed. Otherwise, appears to be playing well.

Temporal shipped in Firefox 139, and is staging in Chromium (shipping in 144).

jakebailey · 2025-10-20T18:24:58Z

We usually don't create tests for lib.d.ts like was done here; they're pretty annoying because they are typically very sensitive to tweaks, new lib.d.ts, etc. I think I missed this in the previous PR from you I merged, though.

Probably we should just delete them?

@typescript-bot test it

typescript-bot · 2025-10-20T18:25:03Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-10-20T18:49:48Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-10-20T18:54:15Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62628/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

Renegade334 · 2025-10-20T18:55:37Z

Probably we should just delete them?

Dealer's choice. I needed them for testing anyway, but if they're of no value within the library then they can just go.

typescript-bot · 2025-10-20T19:15:55Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,219k (± 0.91%)}	_{194,013k (± 0.93%)}	_~	_192,756k	_196,339k	_{p=0.230 n=6}
_{Parse Time}	_{1.31s (± 0.42%)}	_{1.30s (± 0.31%)}	_~	_1.30s	_1.31s	_{p=0.282 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_{0.72s (± 0.57%)}	_~	_0.72s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.76s (± 0.23%)}	_{9.74s (± 0.28%)}	_~	_9.70s	_9.78s	_{p=0.465 n=6}
_{Emit Time}	_{2.74s (± 0.85%)}	_{2.74s (± 0.64%)}	_~	_2.72s	_2.77s	_{p=0.622 n=6}
_{Total Time}	_{14.52s (± 0.18%)}	_{14.52s (± 0.18%)}	_~	_14.48s	_14.55s	_{p=0.872 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_955,117	_955,752	_{+635 (+ 0.07%)}	_~	_~	_{p=0.001 n=6}
_Types	_415,619	_415,621	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,254,564k (± 0.00%)}	_{1,255,717k (± 0.00%)}	_{+1,153k (+ 0.09%)}	_1,255,689k	_1,255,748k	_{p=0.005 n=6}
_{Parse Time}	_{6.49s (± 0.18%)}	_{6.52s (± 0.69%)}	_~	_6.48s	_6.59s	_{p=0.622 n=6}
_{Bind Time}	_1.88s	_{1.90s (± 0.27%)}	_{+0.02s (+ 0.89%)}	_1.89s	_1.90s	_{p=0.002 n=6}
_{Check Time}	_{32.17s (± 0.26%)}	_{32.16s (± 0.27%)}	_~	_32.01s	_32.25s	_{p=0.936 n=6}
_{Emit Time}	_{14.86s (± 0.35%)}	_{14.87s (± 0.56%)}	_~	_14.73s	_14.96s	_{p=0.687 n=6}
_{Total Time}	_{55.39s (± 0.09%)}	_{55.44s (± 0.27%)}	_~	_55.23s	_55.67s	_{p=0.423 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_552,252	_552,252	_~	_~	_~	_{p=1.000 n=6}
_Types	₈₉	₈₉	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{826,973k (± 0.00%)}	_{826,987k (± 0.00%)}	_~	_826,975k	_826,994k	_{p=0.065 n=6}
_{Parse Time}	_{8.59s (± 0.39%)}	_{8.59s (± 0.63%)}	_~	_8.54s	_8.69s	_{p=0.686 n=6}
_{Bind Time}	_{2.19s (± 0.47%)}	_{2.20s (± 0.47%)}	_~	_2.18s	_2.21s	_{p=0.560 n=6}
_{Check Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Emit Time}	_{0.27s (± 3.66%)}	_{0.26s (± 3.10%)}	_~	_0.26s	_0.28s	_{p=0.336 n=6}
_{Total Time}	_{11.05s (± 0.32%)}	_{11.05s (± 0.55%)}	_~	_11.00s	_11.16s	_{p=0.747 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,232	_1,237,239	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,856	_259,870	_{+14 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,486,212k (±11.93%)}	_{2,607,270k (±14.39%)}	_~	_2,364,517k	_3,092,349k	_{p=0.378 n=6}
_{Parse Time}	_{5.19s (± 2.10%)}	_{5.18s (± 1.84%)}	_~	_5.09s	_5.33s	_{p=1.000 n=6}
_{Bind Time}	_{1.76s (± 1.33%)}	_{1.77s (± 1.04%)}	_~	_1.75s	_1.79s	_{p=0.803 n=6}
_{Check Time}	_{35.17s (± 0.57%)}	_{35.26s (± 0.26%)}	_~	_35.14s	_35.39s	_{p=0.173 n=6}
_{Emit Time}	_{3.00s (± 1.81%)}	_{3.00s (± 1.04%)}	_~	_2.97s	_3.04s	_{p=0.810 n=6}
_{Total Time}	_{45.13s (± 0.62%)}	_{45.22s (± 0.34%)}	_~	_44.98s	_45.39s	_{p=0.173 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,232	_1,237,239	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,856	_259,870	_{+14 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,158,673k (± 0.04%)}	_{3,158,859k (± 0.02%)}	_~	_3,157,774k	_3,159,423k	_{p=0.936 n=6}
_{Parse Time}	_{6.87s (± 0.83%)}	_{6.88s (± 0.42%)}	_~	_6.83s	_6.91s	_{p=1.000 n=6}
_{Bind Time}	_{2.15s (± 1.75%)}	_{2.16s (± 1.16%)}	_~	_2.14s	_2.21s	_{p=0.335 n=6}
_{Check Time}	_{42.63s (± 0.39%)}	_{42.60s (± 0.34%)}	_~	_42.47s	_42.83s	_{p=0.575 n=6}
_{Emit Time}	_{3.51s (± 2.65%)}	_{3.52s (± 1.41%)}	_~	_3.42s	_3.55s	_{p=0.688 n=6}
_{Total Time}	_{55.15s (± 0.36%)}	_{55.18s (± 0.21%)}	_~	_55.03s	_55.39s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,534	_262,541	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,035	_104,049	_{+14 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{440,683k (± 0.01%)}	_{440,661k (± 0.01%)}	_~	_440,634k	_440,700k	_{p=0.173 n=6}
_{Parse Time}	_{3.51s (± 1.07%)}	_{3.52s (± 1.10%)}	_~	_3.46s	_3.56s	_{p=0.935 n=6}
_{Bind Time}	_{1.32s (± 1.07%)}	_{1.32s (± 0.74%)}	_~	_1.31s	_1.33s	_{p=0.869 n=6}
_{Check Time}	_{19.04s (± 0.32%)}	_{19.01s (± 0.27%)}	_~	_18.94s	_19.07s	_{p=0.470 n=6}
_{Emit Time}	_{1.53s (± 1.42%)}	_{1.52s (± 0.80%)}	_~	_1.51s	_1.54s	_{p=0.867 n=6}
_{Total Time}	_{25.39s (± 0.27%)}	_{25.37s (± 0.25%)}	_~	_25.30s	_25.45s	_{p=0.469 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₂	₇₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_226,002	_{+635 (+ 0.28%)}	_~	_~	_{p=0.001 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,202k (± 0.05%)}	_{371,083k (± 0.09%)}	_{+882k (+ 0.24%)}	_370,821k	_371,762k	_{p=0.005 n=6}
_{Parse Time}	_{2.83s (± 1.78%)}	_{2.86s (± 0.72%)}	_~	_2.83s	_2.89s	_{p=0.413 n=6}
_{Bind Time}	_{1.60s (± 1.02%)}	_{1.58s (± 0.65%)}	_~	_1.57s	_1.60s	_{p=0.157 n=6}
_{Check Time}	_{16.41s (± 0.39%)}	_{16.45s (± 0.54%)}	_~	_16.34s	_16.58s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.84s (± 0.35%)}	_{20.89s (± 0.43%)}	_~	_20.77s	_21.00s	_{p=0.375 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,948,486	_3,948,486	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,239,521	_1,239,521	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,741,034k (± 0.01%)}	_{3,741,057k (± 0.01%)}	_~	_3,740,702k	_3,741,213k	_{p=1.000 n=6}
_{Parse Time}	_{15.24s (± 0.65%)}	_{15.29s (± 0.52%)}	_~	_15.19s	_15.38s	_{p=0.336 n=6}
_{Bind Time}	_{4.97s (± 0.67%)}	_{5.31s (±15.07%)}	_~	_4.94s	_6.94s	_{p=0.376 n=6}
_{Check Time}	_{103.62s (± 4.59%)}	_{102.96s (± 3.47%)}	_~	_97.72s	_107.23s	_{p=0.689 n=6}
_{Emit Time}	_{37.03s (±15.24%)}	_{36.83s (± 7.55%)}	_~	_31.15s	_38.15s	_{p=0.689 n=6}
_{Total Time}	_{160.86s (± 2.48%)}	_{160.38s (± 1.86%)}	_~	_157.62s	_165.42s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₄₀	₄₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_372,686	_372,686	_~	_~	_~	_{p=1.000 n=6}
_Types	_163,203	_163,203	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{529,022k (± 0.02%)}	_{529,067k (± 0.02%)}	_~	_528,910k	_529,168k	_{p=0.471 n=6}
_{Parse Time}	_{4.50s (± 1.21%)}	_{4.51s (± 0.54%)}	_~	_4.48s	_4.55s	_{p=0.686 n=6}
_{Bind Time}	_{1.92s (± 1.12%)}	_{1.95s (± 0.68%)}	_~	_1.94s	_1.97s	_{p=0.056 n=6}
_{Check Time}	_{22.12s (± 0.22%)}	_{22.11s (± 0.61%)}	_~	_21.90s	_22.23s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.55s (± 0.28%)}	_{28.57s (± 0.42%)}	_~	_28.37s	_28.68s	_{p=0.470 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_676,516	_677,157	_{+641 (+ 0.09%)}	_~	_~	_{p=0.001 n=6}
_Types	_203,680	_203,682	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{578,415k (± 0.03%)}	_{579,239k (± 0.02%)}	_{+824k (+ 0.14%)}	_579,025k	_579,349k	_{p=0.005 n=6}
_{Parse Time}	_{4.20s (± 1.22%)}	_{4.17s (± 0.60%)}	_~	_4.14s	_4.21s	_{p=0.292 n=6}
_{Bind Time}	_{1.34s (± 1.22%)}	_{1.36s (± 0.60%)}	_{+0.02s (+ 1.36%)}	_1.35s	_1.37s	_{p=0.039 n=6}
_{Check Time}	_{20.51s (± 2.02%)}	_{20.54s (± 1.81%)}	_~	_20.26s	_21.03s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_{0.00s (±154.76%)}	_~	_0.00s	_0.01s	_{p=0.174 n=6}
_{Total Time}	_{26.05s (± 1.63%)}	_{26.07s (± 1.41%)}	_~	_25.77s	_26.56s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

bakkot · 2025-10-20T19:26:41Z

There are lot of places in the spec where property bags have "at least one of" constraints (eg. either month or monthCode is mandatory for a DateLikeObject), which can't really be expressed.

Well...

type DateLikeObjectBase = {
    year?: number | undefined;
    era?: string | undefined;
    eraYear?: number | undefined;
    month?: number | undefined;
    monthCode?: string | undefined;
    day: number;
    calendar?: string | undefined;
}
type DateLikeObject = DateLikeObjectBase & ({ month: number } | { monthCode: string });

Possibly it's not worth the additional complexity, though.

typescript-bot · 2025-10-20T19:46:54Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62628/merge:

Everything looks good!

github-project-automation bot added this to PR Backlog Oct 19, 2025

github-project-automation bot moved this to Not started in PR Backlog Oct 19, 2025

typescript-bot assigned RyanCavanaugh Oct 19, 2025

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 19, 2025

Renegade334 force-pushed the lib-esnext-temporal branch from 57f8162 to f8fc33a Compare October 19, 2025 12:33

Renegade334 added 2 commits October 20, 2025 04:26

add lib.esnext.temporal

f6198ff

add proposal-temporal ancillaries to lib.esnext.{date,intl}

9f45da2

Renegade334 force-pushed the lib-esnext-temporal branch from f8fc33a to 9f45da2 Compare October 20, 2025 03:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add lib.esnext.temporal #62628

Add lib.esnext.temporal #62628

Uh oh!

Renegade334 commented Oct 19, 2025 •

edited

Loading

Uh oh!

jakebailey commented Oct 20, 2025

Uh oh!

typescript-bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Oct 20, 2025

Uh oh!

typescript-bot commented Oct 20, 2025

Uh oh!

Renegade334 commented Oct 20, 2025

Uh oh!

typescript-bot commented Oct 20, 2025

tsc

Uh oh!

bakkot commented Oct 20, 2025

Uh oh!

typescript-bot commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add lib.esnext.temporal #62628

Are you sure you want to change the base?

Add lib.esnext.temporal #62628

Uh oh!

Conversation

Renegade334 commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Oct 20, 2025

Uh oh!

typescript-bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 20, 2025

Uh oh!

typescript-bot commented Oct 20, 2025

Uh oh!

Renegade334 commented Oct 20, 2025

Uh oh!

typescript-bot commented Oct 20, 2025

tsc

Uh oh!

bakkot commented Oct 20, 2025

Uh oh!

typescript-bot commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Renegade334 commented Oct 19, 2025 •

edited

Loading

typescript-bot commented Oct 20, 2025 •

edited

Loading