Create a plugin to add a WAL Receiver pod #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgerman
reviewed
Sep 5, 2025
| RUN --mount=type=cache,target=/root/.cache/go-build ./scripts/build.sh | ||
|
|
||
| # Step 2: build the image to be actually run | ||
| FROM golang:1-alpine |
There was a problem hiding this comment.
is this what CNPG does? Or could we go distroless?
There was a problem hiding this comment.
We can do distroless, cnpg uses gcr.io/distroless/static-debian12:nonroot
| // Plugin parameter keys | ||
| const ( | ||
| ImageParam = "image" // string | ||
| ReplicationHostParam = "replicationHost" // Required: primary host |
There was a problem hiding this comment.
isn't that implicit in CNPG?
There was a problem hiding this comment.
CNPG also takes an optional image name
| ) | ||
|
|
||
| const ( | ||
| defaultImage = "ghcr.io/cloudnative-pg/postgresql:16" |
There was a problem hiding this comment.
can we have an image with just the wal reciever?
There was a problem hiding this comment.
I can try to make that, yeah
| "--port", "5432", | ||
| "--username", "postgres", | ||
| "--no-password", | ||
| "--verbose", |
There was a problem hiding this comment.
that should probbaly depend on log level
xgerman
reviewed
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.