Adding kiota msal-browser auth library #233
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Jun 20, 2022
| throw error; | ||
| } | ||
| return response.accessToken; | ||
| } catch (error) { |
Member
There was a problem hiding this comment.
this exception name masks the error variable your have above. Rename this or downscope the other one
| const account = | ||
| this.msalBrowserAuthenticationConfig && | ||
| this.msalBrowserAuthenticationConfig.account; | ||
| const error = new Error(); |
Member
There was a problem hiding this comment.
I'd argue for duplication and instantiating it only if needed. Hopefully the vast majority of executions do not throw an error.
| } from "@azure/msal-browser"; | ||
|
|
||
| export interface MSALBrowserAuthenticationConfig { | ||
| publicClientApplication: PublicClientApplication; |
Contributor
|
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #186