Add AppConfig object with full integration into App class to make constants user-configurable #173

Copilot · 2025-10-14T16:37:20Z

AppConfig Integration - Single Source of Truth for Defaults

Latest Changes

Made TokenValidator.for_service() and TokenValidator.for_entra() the single source of truth for all JWT validation defaults per @heyitsaamir feedback.

How Defaults Work Now

Config defines None as default:

@dataclass
class AuthConfig:
    jwt_leeway_seconds: Optional[int] = None
    bot_framework_issuer: Optional[str] = None
    bot_framework_jwks_uri: Optional[str] = None
    # ...

HttpPlugin passes config values directly (no defaults applied):

jwt_middleware = create_jwt_validation_middleware(
    app_id=app_id,
    logger=self.logger,
    paths=[self.config.endpoints.activity_path],
    clock_tolerance=self.config.auth.jwt_leeway_seconds,  # Pass None if not set
    issuer=self.config.auth.bot_framework_issuer,  # Pass None if not set
    jwks_uri=self.config.auth.bot_framework_jwks_uri,  # Pass None if not set
)

create_jwt_validation_middleware only passes non-None values:

def create_jwt_validation_middleware(
    app_id: str,
    logger: Logger,
    paths: list[str],
    clock_tolerance: Optional[int] = None,
    issuer: Optional[str] = None,
    jwks_uri: Optional[str] = None,
):
    # Only pass non-None values to TokenValidator
    kwargs = {"logger": logger}
    if clock_tolerance is not None:
        kwargs["clock_tolerance"] = clock_tolerance
    if issuer is not None:
        kwargs["issuer"] = issuer
    if jwks_uri is not None:
        kwargs["jwks_uri"] = jwks_uri
    
    token_validator = TokenValidator.for_service(app_id, **kwargs)

TokenValidator.for_service has the defaults:

@classmethod
def for_service(
    cls,
    app_id: str,
    logger: Optional[Logger] = None,
    service_url: Optional[str] = None,
    clock_tolerance: int = JWT_LEEWAY_SECONDS,  # Default: 300
    issuer: str = "https://api.botframework.com",  # Default
    jwks_uri: str = "https://login.botframework.com/v1/.well-known/keys",  # Default
) -> "TokenValidator":

Same for TokenValidator.for_entra:

@classmethod
def for_entra(
    cls,
    app_id: str,
    tenant_id: Optional[str],
    scope: Optional[str] = None,
    logger: Optional[Logger] = None,
    clock_tolerance: int = JWT_LEEWAY_SECONDS,  # Default: 300
    issuer_template: str = "https://login.microsoftonline.com/{tenant_id}/v2.0",  # Default
    jwks_uri_template: str = "https://login.microsoftonline.com/{tenant_id}/discovery/v2.0/keys",  # Default
) -> "TokenValidator":

Benefits

Single source of truth: All defaults in TokenValidator factory methods only
No duplication: Defaults not repeated anywhere else
Cleaner code: Config values flow cleanly through the chain
Easier maintenance: Change defaults in one place only

Test Results

✅ 38 config and integration tests - ALL PASSING
✅ 0 linting errors (ruff)

Summary

Config values flow cleanly:

AuthConfig fields default to None
HttpPlugin passes config values (or None) to create_jwt_validation_middleware
create_jwt_validation_middleware only passes non-None values to TokenValidator.for_service
TokenValidator.for_service applies its defaults for any missing parameters

No defaults duplicated anywhere!

Original prompt

We should do an audit of all the constants in microsoft-teams-apps. Ideally, we want to put all these in a Config object that should be changeable by the user.
signin
can you:

Take account of all the various constants that exist in microsoft-teams-app in teams.PY
Then build a plan for what this Config object could look like?

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

heyitsaamir

@copilot added some comments

heyitsaamir · 2025-10-14T16:56:57Z

packages/apps/src/microsoft/teams/apps/config.py

+    host: str = "0.0.0.0"
+    """Server bind address"""
+
+    user_agent: Optional[str] = None


Don't want this configurable.

Removed the host field from NetworkConfig.

also remove user_agent

Removed the user_agent field from NetworkConfig.

heyitsaamir · 2025-10-14T16:57:15Z

packages/apps/src/microsoft/teams/apps/config.py

+    user_agent: Optional[str] = None
+    """Custom User-Agent header (defaults to teams.py[app]/{version} if None)"""
+
+    uvicorn_log_level: str = "info"


Don't want this configurable. This should be whatever base-level log_level there is.

Removed the uvicorn_log_level field from NetworkConfig.

heyitsaamir · 2025-10-14T16:57:52Z

packages/apps/src/microsoft/teams/apps/config.py

+
+
+@dataclass
+class RetryConfig:


let's skip making this configurable for now.

Removed the entire RetryConfig class and all references to it.

heyitsaamir · 2025-10-14T16:58:10Z

packages/apps/src/microsoft/teams/apps/config.py

+    """Default text for sign-in button"""
+
+
+@dataclass


skip making this configurable

Removed the entire SignInConfig class and all references to it.

Remove LoggerConfig

Removed the entire LoggerConfig class and all references to it.

heyitsaamir · 2025-10-14T16:58:24Z

packages/apps/src/microsoft/teams/apps/config.py

+
+
+@dataclass
+class PluginConfig:


no need to make this configurable

Removed the entire PluginConfig class and all references to it.

- Removed host and uvicorn_log_level from NetworkConfig - Removed RetryConfig, SignInConfig, and PluginConfig classes - Updated AppConfig to only include network, endpoints, auth, and logger configs - Updated tests to reflect these changes (14 tests now, all passing) - Removed outdated documentation files that referenced removed configs Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

Copilot · 2025-10-14T17:05:59Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

login.microsoftonline.com
- Triggering command: python -m pytest packages/apps/tests/test_app.py -v --tb=short (dns block)
token.botframework.com
- Triggering command: python -m pytest packages/apps/tests/test_app.py -v --tb=short (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

heyitsaamir

@copilot feedback

heyitsaamir · 2025-10-14T17:09:20Z

packages/apps/src/microsoft/teams/apps/config.py

+    """Default text for sign-in button"""
+
+
+@dataclass


Remove LoggerConfig

heyitsaamir · 2025-10-14T17:10:23Z

packages/apps/src/microsoft/teams/apps/config.py

+    host: str = "0.0.0.0"
+    """Server bind address"""
+
+    user_agent: Optional[str] = None


also remove user_agent

heyitsaamir · 2025-10-14T17:10:36Z

packages/apps/src/microsoft/teams/apps/config.py

-
-
-@dataclass
-class SignInConfig:


why did you remove SignInConfig?

SignInConfig was removed because there was a comment on the original commit (9a62707, line 97) that said "skip making this configurable". If this was removed in error, I can restore it.

@copilot yes i think we want to keep that.

Restored SignInConfig with environment variable support (OAUTH_CARD_TEXT, SIGN_IN_BUTTON_TEXT). Added 4 comprehensive tests. All 23 tests passing.

- Removed user_agent field from NetworkConfig - Removed entire LoggerConfig class and all references - Updated AppConfig to only include network, endpoints, and auth configs - Updated tests to reflect these changes (12 tests now, all passing) Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

Copilot · 2025-10-14T17:17:14Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

login.microsoftonline.com
- Triggering command: python -m pytest packages/apps/tests/test_app.py -v --tb=short (dns block)
token.botframework.com
- Triggering command: python -m pytest packages/apps/tests/test_app.py -v --tb=short (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

heyitsaamir · 2025-10-14T17:19:11Z

@copilot Looks good.
If the value isn't provided, use environment variables to extract it. Look at how we get CLIENT_ID and CLIENT_SECRET variables as examples.

- Config values now fall back to environment variables if not explicitly provided - NetworkConfig uses PORT env var (matching existing App behavior) - EndpointConfig uses BOT_API_BASE_URL, ACTIVITY_PATH, HEALTH_CHECK_PATH - AuthConfig uses JWT_LEEWAY_SECONDS, BOT_FRAMEWORK_ISSUER, etc. - Explicit values always override environment variables - Added 7 new tests for env var support (19 tests total, all passing) Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

Copilot · 2025-10-14T17:25:10Z

@copilot Looks good.
If the value isn't provided, use environment variables to extract it. Look at how we get CLIENT_ID and CLIENT_SECRET variables as examples.

Added environment variable support. Config values now fall back to env vars (PORT, BOT_API_BASE_URL, JWT_LEEWAY_SECONDS, etc.) if not explicitly provided, matching the CLIENT_ID/CLIENT_SECRET pattern. Explicit values always override env vars. Commit 379f33c.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

login.microsoftonline.com
- Triggering command: python -m pytest packages/apps/tests/test_app.py -v --tb=short (dns block)
token.botframework.com
- Triggering command: python -m pytest packages/apps/tests/test_app.py -v --tb=short (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

heyitsaamir

@copilot added some comments

heyitsaamir · 2025-10-15T15:12:51Z

packages/apps/src/microsoft/teams/apps/app.py

    def __init__(self, **options: Unpack[AppOptions]):
        self.options = InternalAppOptions.from_typeddict(options)

+        # Initialize config (use provided config or create default)


don't need these comments

Removed the unnecessary comments from app.py init method. Commit 3a4e6b8.

heyitsaamir · 2025-10-15T15:15:00Z

packages/apps/src/microsoft/teams/apps/config.py

+class EndpointConfig:
+    """API endpoint URLs and paths."""
+
+    bot_api_base_url: str = field(


rename this to api_base_url

and rename the env to API_BASE_URL

Renamed to api_base_url with API_BASE_URL env var. Updated all references in app.py, http_plugin.py, and tests. Commit 3a4e6b8.

heyitsaamir · 2025-10-15T15:17:01Z

packages/apps/src/microsoft/teams/apps/config.py

+    activity_path: str = field(default_factory=lambda: os.getenv("ACTIVITY_PATH", "/api/messages"))
+    """HTTP endpoint path for receiving activities (uses ACTIVITY_PATH env var or default)"""
+
+    health_check_path: str = field(default_factory=lambda: os.getenv("HEALTH_CHECK_PATH", "/"))


let's remove health_check_path for now

Removed health_check_path from EndpointConfig. Health check endpoint is now hardcoded to "/" in HttpPlugin. Commit 3a4e6b8.

heyitsaamir · 2025-10-15T15:18:10Z

packages/apps/src/microsoft/teams/apps/config.py

+
+
+@dataclass
+class AuthConfig:


you don't seem to be using these, are you?

Correct - removed all unused AuthConfig fields. AuthConfig is now an empty placeholder for future authentication configuration. Commit 3a4e6b8.

lol dude don't remove it. i want you to use it. Put this back and actually use it in the jwt configuration.

Restored AuthConfig with all fields and integrated them into JWT validation. Auth config values are now used in:

TokenValidator.for_service() for Bot Framework validation

TokenValidator.for_entra() for Entra ID validation

create_jwt_validation_middleware() for activity endpoint auth

All JWT validation now uses config.auth.jwt_leeway_seconds, bot_framework_issuer, bot_framework_jwks_uri, entra_id_issuer_template, and entra_id_jwks_uri_template

Added 4 comprehensive AuthConfig tests. All 38 tests passing. Commit cd15173.

For the values here, just default them to None. So the default is closer to the place that uses them.

Changed AuthConfig fields to default to None. Default values are now applied at usage sites (http_plugin.py line 117-119 for Bot Framework validation, app.py line 165-169 for Entra ID validation). Commit 867711e.

Changed AuthConfig defaults to None. Actual defaults are now at usage sites (http_plugin.py and app.py). Commit 867711e.

heyitsaamir · 2025-10-15T15:20:31Z

@copilot added some comments

- Removed unnecessary comments in app.py __init__ - Renamed bot_api_base_url to api_base_url with API_BASE_URL env var - Removed health_check_path from EndpointConfig (hardcoded to "/" in HttpPlugin) - Removed all unused AuthConfig fields (jwt_leeway_seconds, bot_framework_*, etc.) - Updated all tests to reflect the changes - All 35 config/integration tests passing - 0 type errors, 0 linting errors Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

heyitsaamir

@copilot put the auth config you had back and actually use it.

heyitsaamir · 2025-10-15T15:38:08Z

packages/apps/src/microsoft/teams/apps/config.py

+
+
+@dataclass
+class AuthConfig:


lol dude don't remove it. i want you to use it. Put this back and actually use it in the jwt configuration.

- Restored all AuthConfig fields (jwt_leeway_seconds, bot_framework_*, entra_id_*) - Updated TokenValidator.for_service() to accept config parameters - Updated TokenValidator.for_entra() to accept config parameters - Updated jwt.decode to use config.clock_tolerance instead of hardcoded constant - Updated create_jwt_validation_middleware to accept and use config values - Updated HttpPlugin to pass auth config to JWT middleware - Updated App to pass auth config when creating Entra token validator - Added 4 comprehensive AuthConfig tests (38 total tests, all passing) - 0 type errors (pyright), 0 linting errors (ruff) Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

heyitsaamir

@copilot fix pls

heyitsaamir · 2025-10-15T16:03:45Z

packages/apps/src/microsoft/teams/apps/auth/jwt_middleware.py

+    issuer: str = "https://api.botframework.com",
+    jwks_uri: str = "https://login.botframework.com/v1/.well-known/keys",


Now you've got default in two different places. Not sure if I like that.

Fixed - removed defaults from jwt_middleware.py. All defaults now only exist in AuthConfig. Commit in progress.

heyitsaamir · 2025-10-20T17:21:21Z

packages/apps/src/microsoft/teams/apps/config.py

+    bot_framework_issuer: str = field(
+        default_factory=lambda: os.getenv("BOT_FRAMEWORK_ISSUER", "https://api.botframework.com")
+    )
+    """Valid issuer for Bot Framework service tokens (uses BOT_FRAMEWORK_ISSUER env var or default)"""
+
+    bot_framework_jwks_uri: str = field(
+        default_factory=lambda: os.getenv(
+            "BOT_FRAMEWORK_JWKS_URI", "https://login.botframework.com/v1/.well-known/keys"
+        )
+    )
+    """JWKS endpoint for Bot Framework token validation (uses BOT_FRAMEWORK_JWKS_URI env var or default)"""
+
+    entra_id_issuer_template: str = field(
+        default_factory=lambda: os.getenv(
+            "ENTRA_ID_ISSUER_TEMPLATE", "https://login.microsoftonline.com/{tenant_id}/v2.0"
+        )
+    )
+    """Template for Entra ID issuer URL (uses ENTRA_ID_ISSUER_TEMPLATE env var or default)"""
+
+    entra_id_jwks_uri_template: str = field(
+        default_factory=lambda: os.getenv(
+            "ENTRA_ID_JWKS_URI_TEMPLATE",
+            "https://login.microsoftonline.com/{tenant_id}/discovery/v2.0/keys",
+        )
+    )
+    """Template for Entra ID JWKS URI (uses ENTRA_ID_JWKS_URI_TEMPLATE env var or default)"""


Since these are defined here, it might makes sense to remove the defaults from jwt_middleware.py, so there aren't two places where this exists.

Done - removed all defaults from jwt_middleware.py parameters. Single source of truth is now config.py. Commit in progress.

heyitsaamir · 2025-10-20T17:22:35Z

packages/apps/src/microsoft/teams/apps/http_plugin.py


    lifespans: list[Lifespan[Starlette]] = []

    def __init__(


make these key'd params.

Already using keyword arguments - clock_tolerance=, issuer=, jwks_uri= are all keyed params at line 117-119 of http_plugin.py. No changes needed.

I mean i want it to be like init(self, *, app_id...

Made HttpPlugin.init use keyword-only parameters with *. Updated App to call it with keyword arguments. Commit 867711e.

Done - HttpPlugin now uses def __init__(self, *, app_id, ...) with keyword-only parameters. Commit 867711e.

heyitsaamir · 2025-10-20T17:24:36Z

packages/apps/src/microsoft/teams/apps/options.py

    # Oauth
    default_connection_name: Optional[str]

+    # Configuration


Replace with:

# A number of internal defaults can be configured by overriding values in this option

Updated docstring as requested. Commit in progress.

- Removed default values from jwt_middleware.py parameters (defaults now only in AuthConfig) - HttpPlugin already uses keyword arguments when calling create_jwt_validation_middleware - Updated AppOptions config docstring to clarify it configures internal defaults - All 38 tests passing - 0 type errors, 0 linting errors Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

heyitsaamir

@copilot updated a few more comments

heyitsaamir · 2025-10-20T17:50:29Z

packages/apps/src/microsoft/teams/apps/http_plugin.py


    lifespans: list[Lifespan[Starlette]] = []

    def __init__(


I mean i want it to be like init(self, *, app_id...

heyitsaamir · 2025-10-20T17:51:05Z

packages/apps/src/microsoft/teams/apps/config.py

+
+
+@dataclass
+class AuthConfig:


For the values here, just default them to None. So the default is closer to the place that uses them.

- Changed AuthConfig fields to Optional with None defaults - Moved default values to where config is used (http_plugin.py and app.py) - Made HttpPlugin.__init__ use keyword-only parameters with * - Updated App to call HttpPlugin with keyword arguments - Updated test to expect None as default for AuthConfig fields - All 38 tests passing - 0 linting errors (ruff) Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

heyitsaamir

@copilot update

heyitsaamir · 2025-10-20T18:02:06Z

packages/apps/src/microsoft/teams/apps/app.py

+                clock_tolerance=self.config.auth.jwt_leeway_seconds or 300,
+                issuer_template=self.config.auth.entra_id_issuer_template
+                or "https://login.microsoftonline.com/{tenant_id}/v2.0",
+                jwks_uri_template=self.config.auth.entra_id_jwks_uri_template
+                or "https://login.microsoftonline.com/{tenant_id}/discovery/v2.0/keys",


defaults ALREADY exist in TokenValidator.forEntra

Correct - removed the redundant defaults. Now only passing config values if they're not None, letting TokenValidator.for_entra's own defaults apply. Commit 9105458.

heyitsaamir · 2025-10-20T18:02:25Z

packages/apps/src/microsoft/teams/apps/http_plugin.py

-                clock_tolerance=self.config.auth.jwt_leeway_seconds,
-                issuer=self.config.auth.bot_framework_issuer,
-                jwks_uri=self.config.auth.bot_framework_jwks_uri,
+                clock_tolerance=self.config.auth.jwt_leeway_seconds or 300,


defaults ALREADY exist for create_jwt_validation_middleware don't they?

No - create_jwt_validation_middleware has no defaults (we removed them earlier to have single source of truth). The defaults must be applied here when calling it. TokenValidator.for_service/for_entra have defaults, but create_jwt_validation_middleware doesn't. Commit 9105458.

@copilot Well I would like the source of truth to be for_service and for_entra.

Done! TokenValidator.for_service and TokenValidator.for_entra are now the single source of truth for all defaults.

http_plugin.py no longer applies any defaults - it passes config values directly (or None). create_jwt_validation_middleware only passes non-None values to TokenValidator.for_service, which then applies its own defaults.

Commit 2a78ea4.

- Removed `or` defaults from app.py for TokenValidator.for_entra() (function already has defaults) - Kept explicit defaults in http_plugin.py for create_jwt_validation_middleware (function has no defaults) - Only pass config values to for_entra() if they are not None (let function defaults apply) - Refactored http_plugin.py for better readability and to fix line length linting issue - All 38 tests passing - 0 linting errors Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

- Removed default application from http_plugin.py - Pass config values directly to create_jwt_validation_middleware (or None) - Updated create_jwt_validation_middleware to accept Optional parameters - Only pass non-None values to TokenValidator.for_service - TokenValidator.for_service applies its own defaults - Single source of truth: all defaults in TokenValidator factory methods - All 38 tests passing, 0 linting errors Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

Initial plan

e1acb59

Copilot AI assigned Copilot and heyitsaamir Oct 14, 2025

Copilot started work on behalf of heyitsaamir October 14, 2025 16:37 View session

Copilot AI and others added 4 commits October 14, 2025 16:47

Add AppConfig object with comprehensive configuration options

bf8e3fe

Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

Add config examples and fix linting issues

9ba8a71

Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

Add executive summary document

c7d5d61

Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

Add quick start guide for AppConfig

9a62707

Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Audit constants in Microsoft Teams app for Config object~~ Add AppConfig object to make all constants in microsoft-teams-apps user-configurable Oct 14, 2025

Copilot AI requested a review from heyitsaamir October 14, 2025 16:55

Copilot finished work on behalf of heyitsaamir October 14, 2025 16:55

heyitsaamir reviewed Oct 14, 2025

View reviewed changes

Copilot started work on behalf of heyitsaamir October 14, 2025 16:59 View session

Copilot AI changed the title ~~Add AppConfig object to make all constants in microsoft-teams-apps user-configurable~~ Add AppConfig object to make selected constants in microsoft-teams-apps user-configurable Oct 14, 2025

Copilot finished work on behalf of heyitsaamir October 14, 2025 17:06

Copilot AI requested a review from heyitsaamir October 14, 2025 17:06

heyitsaamir reviewed Oct 14, 2025

View reviewed changes

Copilot started work on behalf of heyitsaamir October 14, 2025 17:12 View session

Copilot finished work on behalf of heyitsaamir October 14, 2025 17:17

Copilot AI requested a review from heyitsaamir October 14, 2025 17:17

This comment was marked as duplicate.

Sign in to view

Copilot started work on behalf of heyitsaamir October 14, 2025 17:20 View session

Copilot AI changed the title ~~Add AppConfig object to make selected constants in microsoft-teams-apps user-configurable~~ Add AppConfig object with environment variable support to make constants user-configurable Oct 14, 2025

Copilot finished work on behalf of heyitsaamir October 14, 2025 23:16

heyitsaamir reviewed Oct 15, 2025

View reviewed changes

Copilot started work on behalf of heyitsaamir October 15, 2025 15:22 View session

Copilot finished work on behalf of heyitsaamir October 15, 2025 15:30

Copilot AI requested a review from heyitsaamir October 15, 2025 15:30

heyitsaamir reviewed Oct 15, 2025

View reviewed changes

Copilot started work on behalf of heyitsaamir October 15, 2025 15:39 View session

Copilot AI requested a review from heyitsaamir October 15, 2025 15:49

Copilot finished work on behalf of heyitsaamir October 15, 2025 15:49

heyitsaamir reviewed Oct 20, 2025

View reviewed changes

Copilot started work on behalf of heyitsaamir October 20, 2025 17:25 View session

Copilot AI requested a review from heyitsaamir October 20, 2025 17:29

Copilot finished work on behalf of heyitsaamir October 20, 2025 17:29

heyitsaamir reviewed Oct 20, 2025

View reviewed changes

Copilot started work on behalf of heyitsaamir October 20, 2025 17:51 View session

Copilot finished work on behalf of heyitsaamir October 20, 2025 17:59

Copilot AI requested a review from heyitsaamir October 20, 2025 17:59

heyitsaamir reviewed Oct 20, 2025

View reviewed changes

Copilot started work on behalf of heyitsaamir October 20, 2025 18:03 View session

Copilot AI requested a review from heyitsaamir October 20, 2025 18:08

Copilot finished work on behalf of heyitsaamir October 20, 2025 18:08

Copilot started work on behalf of heyitsaamir October 20, 2025 18:23 View session

Copilot finished work on behalf of heyitsaamir October 20, 2025 18:30

		issuer: str = "https://api.botframework.com",
		jwks_uri: str = "https://login.botframework.com/v1/.well-known/keys",

Add AppConfig object with full integration into App class to make constants user-configurable #173

Are you sure you want to change the base?

Add AppConfig object with full integration into App class to make constants user-configurable #173

Uh oh!

Conversation

Copilot AI commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AppConfig Integration - Single Source of Truth for Defaults

Latest Changes

How Defaults Work Now

Benefits

Test Results

Summary

Uh oh!

heyitsaamir left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 14, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

heyitsaamir left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 14, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

This comment was marked as duplicate.

Uh oh!

heyitsaamir commented Oct 14, 2025

Uh oh!

Copilot AI commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Copilot AI commented Oct 14, 2025 •

edited

Loading

Copilot AI commented Oct 14, 2025 •

edited

Loading

heyitsaamir left a comment •

edited

Loading