Skip to content

Use a different set of commands to detect fourslash test updates #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use a different set of commands to detect fourslash test updates #1923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60ae2d2
Use a different set of commands to detect fourslash test updates
jakebailey Oct 22, 2025
3774646
or true
jakebailey Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,16 @@ jobs:
- run: node --experimental-strip-types ./internal/lsp/lsproto/_generate/generate.mts

- name: Regenerate fourslash tests and update failing test list
run: npm run updatefailing
run: |
echo "" > ./internal/fourslash/_scripts/failingTests.txt
npm run convertfourslash || true
npx hereby test || true
npx hereby baseline-accept || true
npm run updatefailing || true
npx hereby baseline-accept || true
rm -rf testdata/baselines/reference/fourslash || true
npx hereby test || true
npx hereby baseline-accept || true

- run: git add .
- run: git diff --staged --exit-code --stat
Expand Down
Loading