Fix Markdown link in Run Command tool #1462
Merged
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a broken Markdown link in the Run Command tool that displays confirmation messages to users. The previous implementation incorrectly encoded command arguments, preventing the link from working properly when users clicked it.
Key Changes:
- Updated command URI generation to use the
commandUrihelper function instead of manual JSON encoding - Adjusted the trusted command configuration to match the Quick Open command being linked
sandy081
approved these changes
Oct 21, 2025
jruales
force-pushed
the
dev/jruales/fix-run-command-tool-md-link
branch
from
ff109b3 to
d07ca7c
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Fix Markdown link in Run Command tool * Import commandUri in vscodeCmdTool.tsx Add import for commandUri from linkify commands * Use commandId instead of name * Small comment Add comments to clarify command ID handling in Quick Open.
Add import for commandUri from linkify commands
Add comments to clarify command ID handling in Quick Open.
jruales
force-pushed
the
dev/jruales/fix-run-command-tool-md-link
branch
from
d07ca7c to
1d85808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link wasn't working before
Fixes microsoft/vscode#272449
Partial fix for: microsoft/vscode#252415