Added dialog for Arm container error #20324

laurenastrid1 · 2025-10-20T19:04:40Z

Pull Request Template – vscode-mssql

Description

Fixes #20316

Added an error dialog to give more context to arm users when they attempt to start a SQL 2025 container.

Code Changes Checklist

[] New or updated unit tests added
All existing tests pass (npm run test)
Code follows contributing guidelines
Telemetry/logging updated if relevant
No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

github-actions · 2025-10-20T19:15:54Z

PR Changes

Category	Target Branch	PR Branch	Difference
Code Coverage	56.55%	56.55%	⚪ 0.00%
VSIX Size	4867 KB	4868 KB	⚪ 1 KB ( 0% )
Webview Bundle Size	4012 KB	4012 KB	⚪ 0 KB ( 0% )

codecov-commenter · 2025-10-20T19:16:04Z

Codecov Report

❌ Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.52%. Comparing base (b8d588b) to head (4154c9c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/deployment/localContainersHelpers.ts	42.85%	8 Missing ⚠️
src/deployment/deploymentWebviewController.ts	0.00%	2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (44.44%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #20324      +/-   ##
==========================================
+ Coverage   53.53%   54.52%   +0.98%     
==========================================
  Files         192      200       +8     
  Lines       16854    17351     +497     
  Branches     1140     1154      +14     
==========================================
+ Hits         9023     9460     +437     
- Misses       7831     7891      +60

Files with missing lines	Coverage Δ
src/constants/locConstants.ts	`80.77% <100.00%> (+0.04%)`	⬆️
src/deployment/dockerUtils.ts	`86.46% <ø> (+0.18%)`	⬆️
src/sharedInterfaces/connectionDialog.ts	`95.45% <ø> (ø)`
src/sharedInterfaces/localContainers.ts	`91.66% <ø> (-0.34%)`	⬇️
src/deployment/deploymentWebviewController.ts	`9.61% <0.00%> (-0.19%)`	⬇️
src/deployment/localContainersHelpers.ts	`85.61% <42.85%> (-5.43%)`	⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aasimkhan30 · 2025-10-20T21:53:09Z

src/deployment/localContainersHelpers.ts

            options: versions,
+            validate(_state, value) {
+                // Handle ARM64 architecture case where SQL Server 2025 latest is broken
+                const isArm64With2025 = arch() === "arm64" && value.toString().includes("2025");


Aren't all containers broken in arm64 windows?
Isn't this error specific to arm64 Macs only?

just 2025, and on any arm architecture

If it's broken on any ARM machine, why does one of the error messages specify Apple silicon? I'm still confused about which parts of the [SQL version, OS, architecture] matrix are broken.

SQL Server 2025 is not yet supported on Apple Silicon (ARM).

caohai · 2025-10-20T22:50:01Z

Is the gif created from an actual windows arm machine? Or is it just for demonstarting the error message?

laurenastrid1 · 2025-10-21T15:00:57Z

Is the gif created from an actual windows arm machine? Or is it just for demonstarting the error message?

just demonstrating the error message

laurenastrid1 · 2025-10-21T16:54:10Z

@croblesm please take a look, and also provide a link for the arm error docs

Benjin · 2025-10-21T16:57:34Z

src/constants/locConstants.ts

    public static portPlaceholder = l10n.t("Enter port");
    public static hostnamePlaceholder = l10n.t("Enter hostname");
+    public static sqlServer2025ArmError = l10n.t(
+        "SQL Server 2025 is not supported on ARM architecture. Please select a different SQL Server version.",


This reads a bit off grammatically to me. I think

SQL Server 2025 is not supported on ARM architectures.

(pluralizing "architectures") is correct. As would "on the ARM architecture", but I like the former better.

Benjin · 2025-10-21T16:59:56Z

src/deployment/localContainersHelpers.ts

+        arch() === "arm64" &&
+        state.formState.version.includes("2025")
+    ) {
+        state.dialog = {


Can you create an issue for reverting this once CU1 is released (if one doesn't already exist), stick in the January 2026 milestone, and add a link to it in a comment here?

Benjin · 2025-10-21T17:01:30Z

src/deployment/localContainersHelpers.ts

            options: versions,
+            validate(_state, value) {
+                // Handle ARM64 architecture case where SQL Server 2025 latest is broken
+                const isArm64With2025 = arch() === "arm64" && value.toString().includes("2025");


If it's broken on any ARM machine, why does one of the error messages specify Apple silicon? I'm still confused about which parts of the [SQL version, OS, architecture] matrix are broken.

SQL Server 2025 is not yet supported on Apple Silicon (ARM).

Benjin · 2025-10-21T17:03:05Z

src/reactviews/pages/Deployment/LocalContainers/armSql2025ErrorDialog.tsx

+                        </Text>
+                        <Text className={classes.contentItem}>
+                            {Loc.localContainers.see}{" "}
+                            <Link href="https://aka.ms/sql-container-arm">


Nit: pull the URL out into a const if it's also used as the display string for the link.

Copilot

Pull Request Overview

This PR adds an error dialog to inform ARM-based system users (including Windows ARM and Apple Silicon) that SQL Server 2025 RTM containers are not compatible with their architecture. The dialog appears when users attempt to create or select a SQL Server 2025 container on ARM64 systems, with a link to documentation for more details.

Key Changes:

Added a new warning dialog component for ARM SQL 2025 incompatibility
Implemented architecture detection and validation to prevent SQL Server 2025 container selection on ARM64 systems
Removed hardcoded workaround that downgraded SQL Server 2025 to CTP2.0 on ARM systems

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/sharedInterfaces/localContainers.ts	Added reducer and context method for closing the ARM error dialog; removed unused platform property
src/sharedInterfaces/connectionDialog.ts	Extended dialog types to include the new armSql2025Error dialog
src/reactviews/pages/Deployment/deploymentStateProvider.tsx	Registered the closeArmSql2025ErrorDialog action in the deployment state provider
src/reactviews/pages/Deployment/LocalContainers/localContainersInputForm.tsx	Added conditional rendering for the ARM SQL 2025 error dialog
src/reactviews/pages/Deployment/LocalContainers/armSql2025ErrorDialog.tsx	New dialog component displaying ARM incompatibility warning with documentation link
src/reactviews/common/locConstants.ts	Added localized strings for the ARM error dialog content
src/deployment/localContainersHelpers.ts	Implemented ARM64 detection and dialog display logic during initialization and validation; added validation to prevent SQL Server 2025 selection on ARM64
src/deployment/dockerUtils.ts	Removed Mac ARM workaround that forced SQL Server 2025 CTP2.0 version
src/deployment/deploymentWebviewController.ts	Updated controller to propagate dialog state from deployment type state
src/constants/locConstants.ts	Added localized error messages for SQL Server 2025 ARM incompatibility
localization/xliff/vscode-mssql.xlf	Added translation units for new ARM error messages
localization/l10n/bundle.l10n.json	Added localized strings to the bundle

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-21T18:11:27Z

src/reactviews/pages/Deployment/LocalContainers/armSql2025ErrorDialog.tsx

+                    {" "}
+                    <DialogTitle className={classes.titleDiv}>
+                        {" "}


Remove the unnecessary whitespace-only JSX expressions {\" \"} on lines 59 and 61. These are extraneous and serve no functional purpose.

Suggested change

{" "}

<DialogTitle className={classes.titleDiv}>

{" "}

<DialogTitle className={classes.titleDiv}>

Copilot · 2025-10-21T18:11:28Z

src/deployment/localContainersHelpers.ts

+            validate(_state, value) {
+                // Handle ARM64 architecture case where SQL Server 2025 latest is broken
+                const isArm64With2025 = arch() === "arm64" && value.toString().includes("2025");


The arch() function from the os module is called every time this validation runs. Consider caching the result at module level or passing it as part of the state to avoid repeated system calls during form validation.

Copilot · 2025-10-21T18:11:28Z

src/deployment/localContainersHelpers.ts

+                arch() === "arm64"
+                    ? LocalContainers.sqlServer2025ArmErrorTooltip
+                    : LocalContainers.selectImageTooltip,


The arch() system call is made during form component setup. Consider caching the architecture value at module level to avoid repeated system calls, especially since the architecture won't change during the application's lifetime.

Lauren Nathan added 3 commits October 15, 2025 13:49

basic arm workaround, still need to work on error messages

74a4d6f

basic arm error dialog

911e1b9

finished arm error dialog

dd1f089

laurenastrid1 requested review from Benjin, aasimkhan30, allancascante, caohai, kburtram, lewis-sanchez, manujoseph85 and ssreerama as code owners October 20, 2025 19:04

aasimkhan30 reviewed Oct 20, 2025

View reviewed changes

Lauren Nathan added 2 commits October 21, 2025 12:50

Merge branch 'main' into laurenastrid1/armContainerBug

e700569

fixed key reference

4154c9c

Benjin approved these changes Oct 21, 2025

View reviewed changes

allancascante requested a review from Copilot October 21, 2025 18:10

Copilot AI reviewed Oct 21, 2025

View reviewed changes

Added dialog for Arm container error #20324

Are you sure you want to change the base?

Added dialog for Arm container error #20324

Conversation

laurenastrid1 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Template – vscode-mssql

Description

Code Changes Checklist

Reviewers: Please read our reviewer guidelines

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Changes

Uh oh!

codecov-commenter commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aasimkhan30 Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

laurenastrid1 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Benjin Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

caohai commented Oct 20, 2025

Uh oh!

laurenastrid1 commented Oct 21, 2025

Uh oh!

laurenastrid1 commented Oct 21, 2025

Uh oh!

Benjin Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Benjin Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Benjin Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Benjin Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

laurenastrid1 commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading

codecov-commenter commented Oct 20, 2025 •

edited

Loading

Benjin Oct 21, 2025 •

edited

Loading