Set TextDecoder.ignoreBOM to true in VSBuffer #272389
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the Byte Order Mark (BOM) character was being incorrectly stripped during message deserialization in VSBuffer.toString(). The fix ensures the BOM character is preserved by explicitly setting ignoreBOM: true when creating the TextDecoder instance.
Key Changes:
- Modified
TextDecoderinstantiation to preserve BOM characters during UTF-8 decoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #251527
Issue can be replicated with the steps shown in the issue.
DiskFileSystemProvider.readdir() will create a promise which will contain the list of files in our folder, this message is serialized correctly with the BOM character preserved. The issue occurs when ChannelClient.onBuffer() tries to deserialize the message. In VSBuffer.toString() a default instance of TextDecoder is used which has ignoreBOM set to false meaning the BOM character will be stripped.