-
Notifications
You must be signed in to change notification settings - Fork 35.6k
Setting to disable terminal quick fixes #272463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
5df4391
to
63f20de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new user setting terminal.integrated.shellIntegration.quickFixEnabled
that allows users to disable quick fix decorations (lightbulb and AI sparkle icons) in the terminal when commands fail.
Key Changes:
- Added new configuration setting for controlling quick fix decoration visibility
- Implemented runtime checks to respect the setting before showing decorations
- Added dynamic configuration listener to clear decorations when setting changes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
src/vs/platform/terminal/common/terminal.ts |
Added new ShellIntegrationQuickFixEnabled setting ID to the enum |
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts |
Defined configuration schema for the new setting with default value true |
src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts |
Implemented setting check before registering decorations and added configuration change listener |
Implementation Summary
terminal.integrated.shellIntegration.quickFixEnabled
to the terminal configurationTerminalSettingId
enum in/src/vs/platform/terminal/common/terminal.ts
/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
_registerQuickFixDecoration
in/src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts
Solution Overview
Added a new boolean setting
terminal.integrated.shellIntegration.quickFixEnabled
(default:true
) that allows users to disable quick fix decorations in the terminal. This addresses the issue where users find the AI sparkle icon and lightbulb icons distracting when commands fail.Key Features
Usage
To disable quick fix icons:
terminal.integrated.shellIntegration.quickFixEnabled
Or add to
settings.json
:Technical Implementation
_registerQuickFixDecoration()
Original prompt
Fixes #272309
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.