Skip to content

Conversation

@kaipiyann
Copy link
Contributor

@kaipiyann kaipiyann commented Oct 31, 2025

Add _meta field to schema

Motivation and Context

Field meta from the spec is missing
https://modelcontextprotocol.io/specification/2025-06-18/basic#meta

How Has This Been Tested?

Tested with MCP Inspector

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@kaipiyann
Copy link
Contributor Author

kaipiyann commented Nov 1, 2025

And this time I did run all the tests also so it should pass the check.

@chr-hertel
Copy link
Member

I struggle a bit with adding meta also to the attributes - i consider meta rather decoupled from the core schema elements. What was your reasoning here?

@kaipiyann
Copy link
Contributor Author

@chr-hertel I just need it. I tried to make MCP widget for Openai so I need to be able to define _meta for tool and ressource.
Doc : https://developers.openai.com/apps-sdk/build/mcp-server

Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me - thanks 👍

@chr-hertel chr-hertel dismissed CodeWithKyrian’s stale review November 7, 2025 22:30

Requested changes have been applied

@chr-hertel
Copy link
Member

@kaipiyann please squash your changes to a single signed commit

@kaipiyann kaipiyann reopened this Nov 8, 2025
@kaipiyann
Copy link
Contributor Author

@chr-hertel : Signed and squashed !

@chr-hertel chr-hertel merged commit d3a0791 into modelcontextprotocol:main Nov 8, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants