Skip to content

Conversation

@maxisbey
Copy link
Contributor

@maxisbey maxisbey commented Oct 30, 2025

Motivation and Context

This adds 100% coverage by adding # pragma: no cover in a bunch of places.

This is taking over the work from #1354

Currently this PR is set to draft as it's the initial run of doing this for the whole repo. Need to get some eyes on this to make sure we're doing this right.

TODO:

  • Check over this to make sure we're adding no cover in the correct way
  • Ensure the CI is set up to correctly handle
  • Make sure there no # pragma: no cover's added where they shouldn't be, like if the line is actually covered I would want these removed.

How Has This Been Tested?

Breaking Changes

Hopefully nothing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@maxisbey maxisbey marked this pull request as draft October 30, 2025 22:51
@maxisbey maxisbey requested a review from Kludex October 30, 2025 23:15

uv run --frozen coverage run -m pytest -n auto $@
uv run --frozen coverage combine
uv run --frozen coverage report No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to enforce new lines at the end of the file on the pre-commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants