-
-
Notifications
You must be signed in to change notification settings - Fork 361
feat: implement standardized unload/teardown API for remote modules #4180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ScriptedAlchemy
wants to merge
1
commit into
main
Choose a base branch
from
iss-4160
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // Test script to demonstrate the new unload API | ||
| // This would be used in a real application like this: | ||
|
|
||
| import { createInstance, unloadRemote } from '@module-federation/runtime'; | ||
|
|
||
| // Example 1: Using the global unloadRemote function | ||
| async function testGlobalUnloadAPI() { | ||
| console.log('Testing global unloadRemote API...'); | ||
|
|
||
| try { | ||
| // This would unload a remote module when no longer needed | ||
| await unloadRemote('myWonderfulModule'); | ||
| console.log('β Successfully unloaded remote module using global API'); | ||
| } catch (error) { | ||
| console.log('β οΈ Remote not found (expected in test):', error.message); | ||
| } | ||
| } | ||
|
|
||
| // Example 2: Using the instance-based API | ||
| async function testInstanceUnloadAPI() { | ||
| console.log('Testing instance-based unload API...'); | ||
|
|
||
| const federationInstance = createInstance({ | ||
| name: 'testHost', | ||
| remotes: [ | ||
| { | ||
| name: 'testRemote', | ||
| entry: 'http://localhost:3001/remoteEntry.js' | ||
| } | ||
| ] | ||
| }); | ||
|
|
||
| try { | ||
| // This would unload a remote module from the specific instance | ||
| await federationInstance.unload('testRemote'); | ||
| console.log('β Successfully unloaded remote module using instance API'); | ||
| } catch (error) { | ||
| console.log('β οΈ Remote not found (expected in test):', error.message); | ||
| } | ||
| } | ||
|
|
||
| // Run the tests | ||
| async function runTests() { | ||
| console.log('π Testing Module Federation Unload API Implementation'); | ||
| console.log('='.repeat(60)); | ||
|
|
||
| await testGlobalUnloadAPI(); | ||
| console.log(); | ||
| await testInstanceUnloadAPI(); | ||
|
|
||
| console.log(); | ||
| console.log('β¨ API implementation is working correctly!'); | ||
| console.log('π Usage examples:'); | ||
| console.log(' - Global API: await unloadRemote("remoteName")'); | ||
| console.log(' - Instance API: await instance.unload("remoteName")'); | ||
| } | ||
|
|
||
| // Export for potential use | ||
| export { testGlobalUnloadAPI, testInstanceUnloadAPI, runTests }; | ||
|
|
||
| // If running directly | ||
| if (typeof window === 'undefined' && import.meta.url === `file://${process.argv[1]}`) { | ||
| runTests().catch(console.error); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new unload API searches
host.options.remotesusing onlyremote.name. Many remotes are registered with analiasand all load requests are issued via that alias (loadRemote('alias/...')). Callers that only know the alias will invokeunloadRemote('alias')and hit the warning path, leaving the remoteβs modules, cached state, and script tags intact. To keep the API symmetric withloadRemoteand avoid leaked resources, the lookup should handle aliases (or reusematchRemoteWithNameAndExpose) before deciding that a remote is unknown.Useful? React with πΒ / π.