Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

Conversation

@Anemy
Copy link
Member

@Anemy Anemy commented Feb 9, 2021

Current changes:

  • Updates how we use the data-service & connection model for new version (not yet published/pr).
  • Adds slight opacity transition to the modal to make it appearing a little smoother.
  • Removes the animation on the connect modal showing (looks a little nicer now with less movement - will sync with Claudia).
  • Makes the svg connect illustration responsive height (max 40 view height).

Still to do:
Fix connection form connecting title (doesn't currently show port). Could do this in another pr. Existing bug in connection-model

@Anemy Anemy changed the title WIP: Compass connect ux improvements feat: connect ux improvements Feb 9, 2021
Copy link
Contributor

@rose-m rose-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! I'd probably do the other change in another PR (form title)

@Anemy Anemy merged commit 112b233 into master Feb 9, 2021
@Anemy Anemy deleted the connect-ux-improvements branch February 9, 2021 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants