-
Notifications
You must be signed in to change notification settings - Fork 23
CLOUDP-235689: Unify multi-cluster replica sets feature branch #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Julien-Ben
wants to merge
10
commits into
master
Choose a base branch
from
mc-rs-unification-feature-branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.6.0 Release NotesNew Features
Bug Fixes
Other Changes
|
Fix dns Update updateOmDeploymentRs OM registration helpers Update CRDs Todo and throw error Lint Add new scaling test + mock OM connection Add helpers Add scale up to test Extract common getReplicaSetProcessIdsFromReplicaSets read_statefulsets for MongoDB (pytest) Simplify tests Unit tests for state Improve comments, usage of state, replicate agent keys New constants Switch test order Some small e2e Multi cluster tests Naive scaler initialize cluster list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-Cluster Replica Set Support in MongoDB CRD
CLOUDP-235689 - unifying single-cluster and multi-cluster replica set configuration into the MongoDB CRD.
Context
Currently, users must choose between two CRDs:
MongoDB(type: ReplicaSet) - for single-cluster deploymentsMongoDBMultiCluster- for multi-cluster deploymentsThis creates UX confusion, code duplication, and migration barriers. Sharded clusters already solved this with a
topologyfield. This PR applies the same pattern to replica sets.Summary
Extends the MongoDB CRD to support multi-cluster replica sets via
topology: MultiCluster. Core functionality:Implementation follows the helper pattern from sharded cluster controller. State is persisted in annotations (will migrate to ConfigMap later).
Demo: Multi-Cluster Replica Set in Action
Deploying a replica set across 3 Kubernetes clusters with a single MongoDB resource:
After reconciliation:
Pods running across all 3 clusters:
Next steps
Bug:
Code cleanup:
Missing robustness features:
Incomplete validations:
State storage:
Limited test coverage:
Related tickets (for Jira to link them)
CLOUDP-353893, CLOUDP-353896, CLOUDP-353897
Testing
One new E2E test
e2e_multi_cluster_new_replica_set_scale_upwas added to assert we can deploy a replica set and reach Running.New unit test file:
mongodbreplicaset_controller_multi_test.goChecklist
skip-changeloglabel if not needed