fix: separator issue for Windows #406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
reviewed
Jun 9, 2025
| enforce: 'pre', | ||
| resolveId(source) { | ||
| if (finalTransformLibraries.some((lib) => source.includes(`${lib}/styles.css`))) { | ||
| if (allLibs.some((lib) => source.includes(`${lib}/styles.css`))) { |
There was a problem hiding this comment.
Could you move this check to a util function, use that here and add some test that were previously failing.
There was a problem hiding this comment.
@brijeshb42 I've extracted it into a utils file and added some unit tests for it.
- This pull request is to resolve Vite Plugin does not work correctly on Windows #385
- I encountered the
CI test_unitandtest_typeserror, which was resolved in this Pull Request. Once it's merged, it will pass. - I have tested it locally on Windows and Mac and it works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.