Resolve CLocalization / CGUI memory leaks #4527
Merged
+117
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dutchman101
requested changes
Nov 9, 2025
Dutchman101
approved these changes
Nov 9, 2025
Member
|
All code reviews were addressed, and we worked together on some remaining minor issues. |
Dutchman101
pushed a commit
that referenced
this pull request
Nov 9, 2025
* Resolve CLocalization / CGUI memory leaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised in Discord https://canary.discord.com/channels/801330706252038164/801411628600000522/1436840277175308299
CEGUI wasn't being properly cleaned up when GUI recreated (on locale and skin change).
We also have no reason to store 'old locales' in the map in CLocalization, so these are cleared up automatically