feat: Add testing.assert_frame_equal
#3220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Oct 18, 2025
Comment on lines
+231
to
+233
| # TODO(FBruzzesi): Do we even this? What should we check? | ||
| # The best way could be to migrate away from `assert_equal_data` in the test suite | ||
| def test_values_mismatch(constructor: Constructor) -> None: ... |
There was a problem hiding this comment.
Looking for help in finding edge cases here 😇
FBruzzesi
commented
Oct 18, 2025
narwhals/testing/asserts/utils.py
Outdated
Comment on lines
25
to
36
| DataFramesDetail: TypeAlias = ( | ||
| Literal[ | ||
| "columns are not in the same order", | ||
| "dtypes do not match", | ||
| "height (row count) mismatch", | ||
| "implementation mismatch", | ||
| ] | ||
| | str | ||
| # NOTE: `| str` makes the literals above redundant, but they still show | ||
| # up when typing as autocompletion. | ||
| # The reason to have `str` is due to the fact that other details are dynamic | ||
| # and depend upon which columns lead to the assertion error. |
There was a problem hiding this comment.
@dangotbanned do you see a better way of doing this?
There was a problem hiding this comment.
My first thought would be to keep the *Detail aliases for static portion of the message.
I haven't looked through to see how the dynamic stuff works yet - particularly where it is sourced and where it gets inserted - but if you had these things separated into 2 parameters then it might work?
E.g. if you added another parameter with not_thing: str = "", that could just get skipped when empty?
There was a problem hiding this comment.
This example uses None and adds line breaks when you have content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
assert_frame_equal#3129assert_series_equal#2983assert_equal_datatoassert_frame_equal#3221Checklist
If you have comments or can explain your changes, please do so below
50%+ of the changes are docstrings and tests