feat(duplicates): run more often, skip duplicate issues #197
+40
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivkeller
changed the title
avivkeller
force-pushed
the
run-more-often
branch
from
2124e0f to
93c54ab
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to check for existing GitHub issues before creating duplicates, along with scheduling adjustments and calendar logic improvements. The changes allow the tool to detect if a meeting issue already exists and prevent duplicate creation unless explicitly forced.
- Added a
--forceflag to allow bypassing duplicate detection - Implemented
findIssueByTitlefunction to search for existing GitHub issues - Updated scheduling from weekly Monday runs to daily execution
- Refined calendar week bounds calculation and error messaging
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.d.ts | Added force boolean field to CLI configuration interface |
| src/github.mjs | Implemented new findIssueByTitle function to search for existing issues by title |
| src/calendar.mjs | Simplified getWeekBounds logic and updated error message from "current week" to "next week" |
| create-node-meeting-artifacts.mjs | Added duplicate detection logic using findIssueByTitle and new --force CLI option |
| .github/workflows/create-meeting-artifacts-scheduled.yml | Changed cron schedule from weekly (Mondays at 10:00) to daily (midnight) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189
Fixes #196
This PR has the issue generator run once a day, a look a week into the future