Skip to content

Conversation

@avivkeller
Copy link
Member

In the event that a meeting issue is closed before it's creation date, it might be helpful not to recreate the issue

Copilot AI review requested due to automatic review settings October 31, 2025 21:52
@avivkeller
Copy link
Member Author

Assuming that a meeting is cancelled, we don't want to re-open a closed issue

@avivkeller
Copy link
Member Author

For example, nodejs/loaders#263 should not be re-opened

@avivkeller avivkeller requested a review from ovflowd October 31, 2025 21:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the GitHub issue search query in findIssueByTitle to include closed issues in the search results by removing the is:open filter.

  • Removed is:open qualifier from the GitHub issues search query

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ovflowd
Copy link
Member

ovflowd commented Oct 31, 2025

Does the query becomes more expensive? What if I open issues and close them as false positives? So the closed ones will be counted as positive matches...

@avivkeller
Copy link
Member Author

This means that any issue with the same title, closed or open, will cause this to exit early, so yes, it's more expansive

@ovflowd
Copy link
Member

ovflowd commented Oct 31, 2025

Yeah, I'd be a 👎 it should only consider open issues. If an issue gets closed it usually is after the meeting and only usually next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants