Validate RelayState for SLO redirects #242
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the security of SAML Single Logout (SLO) relay state handling by introducing strict validation to prevent open redirect vulnerabilities. It ensures that only safe, relative paths are accepted as relay states, falling back to a default value when unsafe input is detected. Comprehensive tests have been added to verify this behavior.
Security improvements:
validate_relay_statemethod inlib/omniauth/strategies/saml.rbto ensure that only safe, relative paths (starting with/and without a scheme or host) are accepted as relay states, rejecting protocol-relative, absolute URLs, and JavaScript URIs. Unsafe relay states default to a safe value. [1] [2]slo_relay_statelogic to use the new validation, falling back to a default relay state when the provided value is unsafe.urilibrary for proper URI parsing and validation.Testing improvements:
spec/omniauth/strategies/saml_spec.rbto check that unsafe relay states (absolute URLs, protocol-relative URLs, and JavaScript URIs) are rejected and the default relay state is used instead. [1] [2] [3] [4]