Refactor helper method #post_xml from the global scope into the relevant test context #244
+27
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use customizable subject block
…anges-in-describe-block Refactor SAML callback spec helper
gerardo-navarro
changed the title
…dundant-before-post-callback-response Refine SAML callback specs
Contributor
Author
|
@fh1ch @bufferoverflow Hi 👋 Here another small refactoring of the tests that applys some ruby testing best practices. Can you please have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor change to the test setup in
spec/omniauth/strategies/saml_spec.rb. The helper methodpost_xmlwas moved from the global scope into the relevant test context, improving encapsulation and test isolation.