-
Notifications
You must be signed in to change notification settings - Fork 133
feat: add slot to extend the profile fields [Backport #1211] #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/teak
Are you sure you want to change the base?
feat: add slot to extend the profile fields [Backport #1211] #1294
Conversation
* feat: add extended profile fields functionality with context and form components * refactor: replace string literals with FORM_MODE constants in profile fields components * feat: implement BaseField component and refactor field elements to use it * chore: remove unused webpack development configuration file * feat: refactor extended profile fields implementation and remove unused components * feat: update dependencies for frontend-plugin-framework and remove unused dompurify * refactor: simplify pluginProps structure in ExtendedProfileFieldsSlot component * feat: add README and example images for Extended Profile Fields slot * refactor: improve performance & keep consistency * feat: add Additional Profile Fields slot with example implementation and documentation * feat: update custom fields image for Additional Profile Fields slot * fix: reorder import of AdditionalProfileFieldsSlot for consistency * test: fix snapshot * fix: adjust margin in example to avoid oddities on mobile * fix: remove unnecessary empty divs from ProfilePage snapshots
|
Thanks for the pull request, @bra-i-am! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
hey @brian-smith-tcril, could you please help me review this? It is just the backport of the slot for additional profile fields to Teak Thank you so much for your help! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/teak #1294 +/- ##
================================================
- Coverage 66.82% 65.23% -1.59%
================================================
Files 51 53 +2
Lines 856 886 +30
Branches 176 181 +5
================================================
+ Hits 572 578 +6
- Misses 273 297 +24
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR intends to backport #1211 to the Teak release
How Has This Been Tested?
Please follow the instructions from #1211 to test it
Screenshots: