Blog post for mutating webhooks #201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developer-guy
force-pushed
the
feature/mutating-admission-webhook-as-function
branch
from
f65c7e1 to
fa01ad9
Compare
|
Changes have been made in #200 is merged with this PR. |
developer-guy
force-pushed
the
feature/mutating-admission-webhook-as-function
branch
from
fa01ad9 to
6485838
Compare
Waterdrips
suggested changes
Nov 22, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
developer-guy
force-pushed
the
feature/mutating-admission-webhook-as-function
branch
from
6485838 to
e773bb3
Compare
alexellis
reviewed
Nov 23, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
alexellis
reviewed
Nov 23, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
alexellis
reviewed
Nov 23, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
alexellis
reviewed
Nov 23, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
alexellis
reviewed
Nov 23, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
alexellis
reviewed
Nov 23, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
alexellis
reviewed
Nov 23, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
alexellis
reviewed
Nov 23, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
alexellis
reviewed
Nov 23, 2020
alexellis
reviewed
Nov 23, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
alexellis
reviewed
Nov 23, 2020
alexellis
reviewed
Nov 23, 2020
_posts/2020-11-2-kubernetes-webhooks-made-easy-with-openfaas-part-2.md
Outdated
Show resolved
Hide resolved
alexellis
requested changes
Nov 23, 2020
There was a problem hiding this comment.
The basic flow is good, but the example needs work. We want users to identify with the use-case and to potentially try it out, not print hello world to the disk of every container. So please take a detailed read of the feedback and think about how we can make this something everyone will want to try.
|
/set title: Blog post for mutating webhooks |
derek
bot
changed the title
alexellis
reviewed
Nov 23, 2020
developer-guy
force-pushed
the
feature/mutating-admission-webhook-as-function
branch
3 times, most recently
from
7399a1f to
849da43
Compare
Everything seems fine to me, I made changes according to your reviews, thank you |
developer-guy
force-pushed
the
feature/mutating-admission-webhook-as-function
branch
from
849da43 to
882b388
Compare
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
developer-guy
force-pushed
the
feature/mutating-admission-webhook-as-function
branch
from
882b388 to
eb0bc40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This time, we are implementing Mutating Admission Webhook as OpenFaaS Function
Types of changes
Checklist:
git commit -s