-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OLS-2269: Update BYOK frontmatter #101727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lightspeed-docs-main
Are you sure you want to change the base?
Conversation
|
@rh-tokeefe: This pull request references OLS-2269 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rh-tokeefe: This pull request references OLS-2269 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Thu Nov 06 12:49:23 - Prow CI generated the docs preview: |
|
LGTM |
|
@rh-tokeefe: This pull request references OLS-2269 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, Tim! LGTM.
Only a small suggestion for you to consider. :)
Peer review done.
| :_mod-docs-content-type: CONCEPT | ||
| [id="about-document-title-and-url_{context}"] | ||
| = About document title and URL | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [role="_abstract"] |
Suggestion to add "[role="_abstract"]" at the beginning of your module. Feel free to skip this if you're planning to cover this separately for your docs set. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyasiddhartha I was planning to address this using the tool, but this is a new file so I might as well start building the practice of making sure it's in the files. Thanks for the suggestion!
Pushed the change.
|
@rh-tokeefe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Affects:
lightspeed-main
lightspeed-docs-1.0
PR must be CP'd back to the lightspeed-docs-1.0 branch.
Version(s): 1.0
Issue: https://issues.redhat.com/browse/OLS-2269
Link to docs preview:
QE review:
Additional information: