Replace ControlLinearNode operator overloads with utility functions
#4188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbianco
force-pushed
the
remove_control_linear_node_operator_overloads
branch
2 times, most recently
from
ecb0bf5 to
6d18908
Compare
aymanhab
approved these changes
Nov 11, 2025
Member
aymanhab
left a comment
aymanhab
left a comment
There was a problem hiding this comment.
@aymanhab reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nickbianco)
nickbianco
force-pushed
the
remove_control_linear_node_operator_overloads
branch
from
6d18908 to
bc0ef87
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4095
Brief summary of changes
Rather than looking for a very specific fix to the operator overload issue in
ControlLinearNode, this change removes the operator overloads entirely in favor of the utility functionsisEqual()andisLessThan(). While a breaking change,ControlLinearNodeis used almost exclusively byControlLinear(one other usage byCMC), and I doubt many users interact with this class directly.IMO,
ControlLinearandControlLinearNodeseem overly complicated for what they accomplished should probably be deprecated in favor of solutions specific to the needs ofCMCand other dependent tools.Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is