resolve the Issue #100 columnname is the constraint not quoted #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
shelly-li-sl
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where column names in table-level CHECK constraints were not properly quoted when generating CREATE TABLE statements for Oracle databases.
Fixes #100
Changes
we look at each field (column) in the schema.
If the column name appears in the constraint, it uses a regex with word boundaries (\b) to replace only whole words, avoiding partial matches (like "doc" inside "document").
and we use the
QuoteIdentifier(f.DBName)to quotes the column name.This ensures the final SQL looks like:
CONSTRAINT "doc_is_json_lax" CHECK ("doc" IS JSON(LAX))