Skip to content

Conversation

@saumil-oracle
Copy link
Contributor

@saumil-oracle saumil-oracle commented Oct 31, 2025

Test coverage of Oracle-specific behavior for Date datatype.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saumil-oracle saumil-oracle self-assigned this Oct 31, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 31, 2025
@saumil-oracle saumil-oracle changed the title Tests for Oracle DATE type covering edge, null, range, update, and in… Tests for Oracle DATE type covering edge, null, range, update Oct 31, 2025
Copy link
Member

@jawad-arb123 jawad-arb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding the tests!

@ting-lan-wang
Copy link
Contributor

The pipeline has been fixed in a recent PR. Can you please update the branch rerun the test?

@saumil-oracle
Copy link
Contributor Author

Even with the most recent main branch, tests continue to fail. There are no issues with the newly added tests of this PR.

@jawad-arb123
Copy link
Member

You should just re-run the pipeline, all the tests will pass. I’ve already done it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants