Fixes sources jar path #58
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
jacobperron
reviewed
Mar 31, 2021
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Is there something that isn't working, prompting this change?
| cmake_parse_arguments(_add_source_jar | ||
| "" | ||
| "OUTPUT_NAME" | ||
| "OUTPUT_NAME;JAR_ROOT_PATH" |
There was a problem hiding this comment.
On one hand, it seems like it should be the responsibility of the caller to remove any prefix paths, but on the other hand it's convenient to let the function take care of it. The downside of letting this function remove the prefix is that it is assuming that all source files have the same prefix.
I think it would safer to instead let the caller deal with the prefix and they can inform this function by passing a WORKING_DIRECTORY argument used when calling the jar command below.
Please add documentation for the new argument to the docblock above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look at the compiled jar their internal paths have the form: org.ros2.rcljava.*. While the sources jar has an internal path that starts in ${CMAKE_CURRENT_SOURCE_DIR}.
This is an attempt to fix that
Signed-off-by: Gonzalo de Pedro gonzalo@depedro.com.ar