correct handling result of CPTRetriveNode

[chenuduss]

what

correct handling result of CPTRetriveNode().

why

Function CPTRetriveNode may return NULL, and null check required

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[airween]

Hi @chenuduss,

thanks for this PR, nice catch.

Just out of curiosity: have you faced any problem in practice with this error?

Or how did you catch it?

Btw: the PR looks good to me so after the discussion I'm going to merge this. And thanks again!

Note: in v2 this was fixed last year, see this PR. But as I see v2 contained already this explicit node check. This is interesting, because many functions were just copied from v2 into v3, and it seems like the author left the node check part.

[chenuduss]

Just out of curiosity: have you faced any problem in practice with this error?
Or how did you catch it?

I found this using a static analyzer.

[airween]

Thanks again @chenuduss!