Skip to content

Fix: Pass the parameter "options" to the function " splitBoolean" #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix: Pass the parameter "options" to the function " splitBoolean" #2028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77fc868
passing options to splitBoolean function
slotDumpling Apr 22, 2023
286e2c0
Merge pull request #1 from slotDumpling/split-boolean-options
slotDumpling Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/path/PathItem.Boolean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ PathItem.inject(new function() {
// based boolean operations (options.split = true).
if (options && (options.trace == false || options.stroke) &&
/^(subtract|intersect)$/.test(operation))
return splitBoolean(path1, path2, operation);
return splitBoolean(path1, path2, operation, options);
// We do not modify the operands themselves, but create copies instead,
// fas produced by the calls to preparePath().
// NOTE: The result paths might not belong to the same type i.e.
Expand Down Expand Up @@ -215,7 +215,7 @@ PathItem.inject(new function() {
return createResult(paths, true, path1, path2, options);
}

function splitBoolean(path1, path2, operation) {
function splitBoolean(path1, path2, operation, options) {
var _path1 = preparePath(path1),
_path2 = preparePath(path2),
crossings = _path1.getIntersections(_path2, filterIntersection),
Expand Down Expand Up @@ -251,7 +251,7 @@ PathItem.inject(new function() {
}
// At the end, add what's left from our path after all the splitting.
addPath(_path1);
return createResult(paths, false, path1, path2);
return createResult(paths, false, path1, path2, options);
}

/*
Expand Down Expand Up @@ -1220,7 +1220,7 @@ PathItem.inject(new function() {
*/
divide: function(path, options) {
return options && (options.trace == false || options.stroke)
? splitBoolean(this, path, 'divide')
? splitBoolean(this, path, 'divide', options)
: createResult([
this.subtract(path, options),
this.intersect(path, options)
Expand Down