Skip to content

chore: fix demo code review commends #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: fix demo code review commends #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/demo/src/lib/components/EventsPanel.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<script lang="ts">
import { onDestroy } from 'svelte';
import type { createFlowState } from '$lib/stores/pgflow-state.svelte';
import { Card, CardContent, CardHeader, CardTitle } from '$lib/components/ui/card';
import { Play, CheckCircle2, XCircle } from '@lucide/svelte';
Expand Down Expand Up @@ -26,6 +27,10 @@
};

mediaQuery.addEventListener('change', updateMobile);

onDestroy(() => {
mediaQuery.removeEventListener('change', updateMobile);
});
}

// Helper to get short step name
Expand Down
35 changes: 23 additions & 12 deletions apps/demo/src/lib/components/ExplanationPanel.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="ts">
import { createEventDispatcher, onMount } from 'svelte';
import { createEventDispatcher, onMount, onDestroy } from 'svelte';
import { fade } from 'svelte/transition';
import { Button } from '$lib/components/ui/button';
import { codeToHtml } from 'shiki';
Expand Down Expand Up @@ -46,7 +46,11 @@
reliabilityFeatures: [
{
setting: 'maxAttempts: 2',
explanation: 'Automatically retries failed steps up to 3 times before giving up'
explanation: 'Automatically retries failed steps up to 2 times before giving up'
},
{
setting: 'baseDelay: 1',
explanation: 'Initial retry delay of 1 second, doubling with each retry (1s, 2s, 4s...)'
}
],
inputType: `{
Expand Down Expand Up @@ -169,6 +173,10 @@
};

mediaQuery.addEventListener('change', updateMobile);

onDestroy(() => {
mediaQuery.removeEventListener('change', updateMobile);
});
}

// Replace long strings with placeholders for mobile display
Expand Down Expand Up @@ -596,20 +604,23 @@
</div>
</details>

<!-- Reliability Features -->
<div>
<div class="font-semibold text-muted-foreground mb-1.5 text-sm">
Reliability Configuration
</div>
<div class="space-y-2">
<!-- Reliability Configuration (collapsible) -->
<details class="concept-explainer bg-background/50 border border-border rounded-lg">
<summary
class="font-semibold text-sm text-foreground cursor-pointer hover:bg-background/80 flex items-center gap-2 p-3 rounded-lg transition-colors"
>
<span class="concept-caret">▸</span>
<span class="flex-1">Reliability configuration</span>
</summary>
<div class="text-xs text-muted-foreground leading-relaxed px-3 pb-3 space-y-2">
{#each flowInfo.reliabilityFeatures as feature (feature.setting)}
<div class="bg-secondary/50 rounded p-2.5">
<code class="text-xs font-mono text-primary">{feature.setting}</code>
<p class="text-xs text-muted-foreground mt-1">{feature.explanation}</p>
<div>
<code class="bg-muted px-1 rounded font-mono text-primary">{feature.setting}</code>
- {feature.explanation}
</div>
{/each}
</div>
</div>
</details>

<!-- Steps -->
<div>
Expand Down
Loading