Fix macOS ARM64 build for picodata #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix macOS ARM64 build for picodata via tarantool-sys
This PR updates the
tarantool-syssubmodule to fix build issues ofpicodata/picodata on macOS ARM64
(Apple Silicon).
Problem description
When building
picodataon macOS ARM64:CMAKE_OSX_SYSROOTwas unset, causing bundled dependencies (SASL, LDAP,autotools-based libs) to fail with missing headers or unresolved symbols.
xxhashsub-build used-Ofast, which produced compatibility issues onApple Clang.
compiler ID checks.
smallsubmodule leaked its root directory into include paths, breakingbuilds.
ExternalProject_Add, the macOS SDK path was not propagated, leading toinconsistent sysroot usage in child projects.
As a result,
picodatacould not be built frommasteron Apple Silicon.Fixes
CMAKE_OSX_SYSROOTautomatically viaxcrun --show-sdk-path.-DCMAKE_OSX_SYSROOTexplicitly toExternalProject_Addon macOS.-Ofastwith-O3forxxhash.-static-libstdc++.INCLUDE_DIRECTORIESforsmalltargets.Result
With this update in
tarantool-sys, thepicodata/picodataproject buildssuccessfully on macOS ARM64.