Skip to content

Conversation

@alastori
Copy link
Collaborator

What is changed, added or deleted? (Required)

  • add an Amazon S3 import guide tailored to TiDB Cloud Premium
  • align MySQL CLI, CSV import, and migration docs with the new Premium workflow
  • document IAM role creation via the CloudFormation helper and manual fallback

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @alastori, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the documentation for TiDB Cloud Premium, focusing on various data import and migration strategies. It introduces new guides for importing CSV data from Amazon S3 and Alibaba Cloud OSS, details how to use the MySQL Command-Line Client for data imports, and provides a comprehensive workflow for migrating data from self-managed TiDB clusters to TiDB Cloud Premium. A key aspect of these new documents is the clear instruction on configuring IAM roles for secure cloud storage access, offering both automated CloudFormation and manual setup options.

Highlights

  • New S3 Import Guide: A dedicated Amazon S3 import guide tailored for TiDB Cloud Premium has been added.
  • Premium Workflow Alignment: Existing documentation for MySQL CLI, CSV import, and general migration processes has been updated and aligned with the new TiDB Cloud Premium workflows.
  • IAM Role Documentation: Detailed instructions for creating necessary IAM roles, including a CloudFormation helper and manual fallback steps, are now documented for cloud storage access.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive documentation for TiDB Cloud Premium import workflows, covering CSV imports, MySQL CLI usage, S3 integration, and migration from self-managed TiDB. The new documents are well-structured and detailed. My review focuses on improving clarity, correcting minor grammatical and technical errors, and ensuring consistency with the repository's style guide. I've provided specific suggestions to enhance readability and accuracy.

alastori and others added 2 commits October 24, 2025 21:27
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@qiancai qiancai added for-cloud-release This PR is related to TiDB Cloud release. translation/doing This PR's assignee is translating this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. translation/doing This PR's assignee is translating this PR. labels Oct 27, 2025
@lilin90 lilin90 self-assigned this Oct 27, 2025
@lilin90 lilin90 changed the title Document Premium import workflows cloud: document Premium import workflows Oct 27, 2025
@alastori
Copy link
Collaborator Author

@zoubingwu @yitso for tech review.
cc @lilin90

Replaced hardcoded 'TiDB Cloud Premium' references with the '{{{ .premium }}}' variable throughout the migration documentation for improved maintainability and dynamic branding.
Revised terminology to consistently use 'instance' instead of 'cluster' for TiDB Cloud Premium. Improved step-by-step instructions for data import and incremental replication, clarified IAM role creation, and enhanced overall clarity and accuracy throughout the migration documentation.
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 29, 2025

@zoubingwu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 29, 2025

@yitso: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 29, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 29, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-29 10:29:57.774046338 +0000 UTC m=+1472503.851298897: ☑️ agreed by lilin90.

@lilin90
Copy link
Member

lilin90 commented Oct 29, 2025

/approve

@lilin90 lilin90 added the lgtm label Oct 29, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 29, 2025
@ti-chi-bot ti-chi-bot bot merged commit 1979c09 into pingcap:release-8.5 Oct 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants