-
-
Notifications
You must be signed in to change notification settings - Fork 178
Explain how to switch to add native namespace #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0
Are you sure you want to change the base?
Conversation
|
@gforcada this is a how-to guide for developers, so it belongs in I'll do a thorough non-technical review after the technical structure and details are reviewed and approved. Thank you! |
mauritsvanrees
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, but I made some suggestions.
ea7e8c2 to
821ce78
Compare
|
@mauritsvanrees thanks for all the tips and improvements! 🙇🏾 that's much better ✨ @stevepiercy I moved the file to the location you suggested and add a ToC entry. Now is probably the time to improve the wording, which probably needs plenty 😅 |
821ce78 to
def1b04
Compare
5e9db80 to
3b26e46
Compare
|
@gforcada I requested another review from @mauritsvanrees, and I'd like @davisagli to review as well, before I make my final pass for non-technical stuff. |
To go along with the PLIP 3928.
3b26e46 to
3c28522
Compare
To go along with the plone/Products.CMFPlone#3928
Disclaimer: I have no idea where would be the best place to put this documentation within the structure, and probably the admonitions style is not the right one.
We can polish, but before nitpicking on this details, let's agree on the structure of the document and if it explains all the relevant steps and are clear enough.
Once that's done we can do the polish.
@mauritsvanrees @davisagli: given a random Plone contributor, do you think the steps cover all the steps, and are clear enough? I made it generic enough (with tips to skip sections) so that it can be reused for
collectiveor private packages, where we can not convert all ourselves.📚 Documentation preview 📚: https://plone6--1981.org.readthedocs.build/