feat: Add PowerSyncDataConvertible protocol #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables downstream consumers to define how certain types should be mapped to those that are supported by the PowerSync Kotlin Multiplatform SDK.
CrownedPhoenix
commented
Oct 24, 2025
Comment on lines
+5
to
+12
| public enum PowerSyncDataType { | ||
| case bool(Bool) | ||
| case string(String) | ||
| case int64(Int64) | ||
| case int32(Int32) | ||
| case double(Double) | ||
| case data(Data) | ||
| } |
There was a problem hiding this comment.
If there is a way to rework this such that the Swift SDK doesn't have to be amended each time support for a new type is added to the Kotlin SDK that would be ideal.
So far as I can figure it would require a mapping function defined by the consumer/user to be passed across the Kotlin SKIE boundary. I'm not familiar enough with Kotlin SKIE to know what that would entail off the top of my head.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables downstream consumers to define how certain types should be mapped to those that are supported by the PowerSync Kotlin Multiplatform SDK.