Add limit and offset configuration options
#224
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `limit` (default `1000`) and `offset` parameters for `here_now` to fetch presence in portions.
Fix issue because of which it was possible to add duplicated entries of `channels` and `groups` to the `subscribe`, `heartbeat`, and `leave` requests.
parfeon
added
status: done
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Add missing presence and subscribe acceptance test steps definition. refactor(subscribe): check for `t` presence in response Refactor `handshake` and `receive` subscribe `effects` to check for cursor presence in response (adjustment for acceptance tests server).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(here-now): add
limitandoffsetconfiguration optionsAdd
limit(default1000) andoffsetparameters forhere_nowto fetch presence in portions.fix(subscribe-heartbeat): fix duplicated channels issue
Fix issue because of which it was possible to add duplicated entries of
channelsandgroupsto thesubscribe,heartbeat, andleaverequests.