Refactor resizing logic and avoid mismatch between last resize event and draw #120
+131
−167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
Instead of backends needing to implement
_rc_get_physical_size,_rc_get_logical_sizeand_rc_get_pixel_ratio, they must now call_set_size_info()whenever their size changes. Backends should also not submit a resize event, the base canvas now handles that.The base class will now emit a resize event right before processing other events, but also right before doing the draw, if the size has changed since events were processed. This fixes #56.
Another benefit is that the backends become simpler, and the getters like
get_physical_size()may be faster because values are read from the base class's cache, instead of calculated from the backend.