Skip to content

Conversation

@akamat10
Copy link
Contributor

@akamat10 akamat10 commented Aug 28, 2024

Type of Changes

Type
🐛 Bug fix

Description

@akamat10
Copy link
Contributor Author

One thing this fix needs to consider is how the order of module discovery changes based on whether a user calls:

python3.12 pkg/script.py

vs

python3.12 -m pkg.script

The difference in behavior is described here in a stackoverflow post.

The test fixes to test_nonregr_absolute_import case will now match the former case but perhaps some thought needs to be given to the latter case and have some test cases around it.

@codecov
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (a389ef7) to head (04fbce5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
+ Coverage   92.98%   93.02%   +0.03%     
==========================================
  Files          93       93              
  Lines       11049    11052       +3     
==========================================
+ Hits        10274    10281       +7     
+ Misses        775      771       -4     
Flag Coverage Δ
linux 92.89% <100.00%> (+0.03%) ⬆️
pypy 93.02% <100.00%> (+0.03%) ⬆️
windows 93.00% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/nodes/_base_nodes.py 94.31% <100.00%> (+0.06%) ⬆️
astroid/nodes/scoped_nodes/scoped_nodes.py 92.79% <100.00%> (ø)

... and 2 files with indirect coverage changes

@jacobtylerwalls jacobtylerwalls modified the milestones: 3.3.3, 3.4.0, 3.3.4 Sep 20, 2024
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 3.3.4, 3.3.5 Sep 23, 2024
@jacobtylerwalls jacobtylerwalls modified the milestones: 3.3.5, 3.3.6 Oct 4, 2024
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 3.3.6, 3.3.7 Dec 8, 2024
@Pierre-Sassoulas Pierre-Sassoulas added the Needs review 🔍 Needs to be reviewed by one or multiple more persons label Dec 8, 2024
@Pierre-Sassoulas
Copy link
Member

Sorry for not reviewing this sooner, this is the kind of change that are hard to assess/test and it's frightening 😅

@akamat10
Copy link
Contributor Author

No need to be sorry. I should reevaluate this given it has been a while since I have looked at this one.

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 3.3.7, 3.3.8 Dec 19, 2024
@jacobtylerwalls jacobtylerwalls modified the milestones: 3.3.8, 3.3.9 Dec 24, 2024
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 3.3.9, 3.3.10 Mar 8, 2025
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 4.0.0 milestone Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🪳 Needs review 🔍 Needs to be reviewed by one or multiple more persons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants